Closed
Bug 1298882
Opened 8 years ago
Closed 8 years ago
ensure mozilla/mscom/Utils.h is included with uniform casing
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
3.12 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
We install mozilla/mscom/Utils.h, but include it with an all-lowercased path in some places. clang-cl warns about this, and even though this is Windows-only code and will therefore work, it's better to make everything consistent.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8786033 -
Flags: review?(aklotz)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8786033 [details] [diff] [review] ensure mozilla/mscom/Utils.h is included with uniform casing Review of attachment 8786033 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #8786033 -
Flags: review?(aklotz) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/65d3f6171572 ensure mozilla/mscom/Utils.h is included with uniform casing; r=aklotz
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/65d3f6171572
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•