1299224 - Add click support to AS topsites

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[Andrzej Hunt :ahunt]

Clicking on TopSites does nothing right now.

We need to:
1 - add OnUrlOpenListener plumbing to ActivityStream
2 - hook the topsites view up to open pages when selected

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1299224 - Pre: remove unnecessary LoaderManager reference from StreamAdapter

I think originally I wanted to fiddle the Loaders from the Adapter, but we don't do that
so this code is unused/unnecessary. We should also make sure we only ever create one adapter,
which we can do by initalising it in the constructor.

Review commit: https://reviewboard.mozilla.org/r/75780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75780/

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1299224 - pass OnUrlOpenListener into StreamRecyclerAdapter

This has the side effect of enabling click support for topsites.

Review commit: https://reviewboard.mozilla.org/r/75782/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75782/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8786907 [details]
Bug 1299224 - Pre: remove unnecessary LoaderManager reference from StreamAdapter

https://reviewboard.mozilla.org/r/75780/#review73922

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:22
(Diff revision 1)
> -import org.mozilla.gecko.home.HomeFragment;
> -import org.mozilla.gecko.home.HomeScreen;
>  import org.mozilla.gecko.home.SimpleCursorLoader;
>  import org.mozilla.gecko.home.activitystream.topsites.TopSitesPagerAdapter;
>  
>  public class ActivityStream extends FrameLayout {

Unrelated: Didn't we want to rename this so that we do not have two classes named "ActivityStream"?

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:40
(Diff revision 1)
>          RecyclerView rv = (RecyclerView) findViewById(R.id.activity_stream_main_recyclerview);
>  
> -        // TODO: we need to retrieve BrowserApp and pass it in as onUrlOpenListener. That will
> -        // be simpler once we're a HomeFragment, but isn't so simple while we're still a View.
> -        adapter = new StreamRecyclerAdapter(lm, null);
>          rv.setAdapter(adapter);
>          rv.setLayoutManager(new LinearLayoutManager(getContext()));
>          rv.setHasFixedSize(true);

Can't you do those assignments in the constructor too? inflate() should return the inflated view on which you can call findViewById().

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8786908 [details]
Bug 1299224 - pass OnUrlOpenListener into StreamRecyclerAdapter

https://reviewboard.mozilla.org/r/75782/#review73930

Comment 5

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/35b31a0d906aa6d618feb11592aaa5aec924db49
Bug 1299224 - Pre: remove unnecessary LoaderManager reference from StreamAdapter r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/3d376f300eac2ed52d331a47b4608c7719013bae
Bug 1299224 - pass OnUrlOpenListener into StreamRecyclerAdapter r=sebastian

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/35b31a0d906a
https://hg.mozilla.org/mozilla-central/rev/3d376f300eac