1299350 - If a homepage is set, it should be displayed at the end of the welcome wizard

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android partner distribution, defect)

Description

[Mike Kaply [:mkaply]]

Currently when you click "Start browsing" at the end of the welcome wizard, it goes straight to the URL bar for editing.

If you have a homepage, it should show at the end of the wizard.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Only enter edit mode if there is no homepage

This should really only affect distributions because they would have a homepage set when the wizard appears.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8786561 [details] [diff] [review]
Only enter edit mode if there is no homepage

Review of attachment 8786561 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ +2751,5 @@
>              mFirstrunAnimationContainer.registerOnFinishListener(new FirstrunAnimationContainer.OnFinishListener() {
>                  @Override
>                  public void onFinish() {
> +                    if (mFirstrunAnimationContainer.showBrowserHint() &&
> +                        TextUtils.isEmpty(getHomepage())) {

This does I/O unless it's already been run, and if it's already been run it'll be as a side-effect (e.g., of telemetry).

Are you confident that this won't spew strictmode warnings?

Comment 3

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91956c5e327190081112ece804cb3ddfeee36e5a
Bug 1299350 - If there is a homepage, show it at the end of the wizard. r=rnewman

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 8786561 [details] [diff] [review]
Only enter edit mode if there is no homepage

Approval Request Comment
[Feature/regressing bug #]: Wizard should navigate to homepage at the end.
[User impact if declined]: At end of wizard, partner homepage doesn't show.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low - only applies for distributions (homepage at startup)
[String/UUID change made/needed]: None

I am asking for this for release because we are looking to have a one off done for a partner with this fix and bug 1299162

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/91956c5e3271

Comment 6

[Alex Caziuc]

This should really only affect distributions because they would have a homepage set when the wizard appears. So I'm changing the component.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Mike, could you please comment on the test coverage section of the uplift request? Are there automated tests for this already? If not, did you manually test it?

Comment 8

[Mike Kaply [:mkaply]]

> Hi Mike, could you please comment on the test coverage section of the uplift request? Are there automated tests for this already? If not, did you manually test it?

It has been manually tested by me and by the partner. Unfortunately it is a difficult solution to test as it requires a rooted device with a homepage set in the distribution, so it cannot be automated.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/releases/mozilla-release/rev/43f96302c08f

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8786561 [details] [diff] [review]
Only enter edit mode if there is no homepage

Last minute fix for welcome screen for partner deal. 
Let's do it.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/92ea0f08b49c
https://hg.mozilla.org/releases/mozilla-beta/rev/101e643d0f73

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1dd122df9806