Closed Bug 1299677 Opened 8 years ago Closed 2 years ago

bitmasksForCategory for CATEGORY_MASK is using a string sort on Numbers

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect

Tracking

(firefox51 affected)

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox51 --- affected

People

(Reporter: MattN, Unassigned)

References

(
URL
)

Details

> If the category is mapped to by multiple masks, CATEGORY_MASK for that name must be called with an additional argument specifying the desired id (in ascending order).

The code seems to be unintentionally using a string sort on the masks so while it may be "ascending order" it may not be the order expected (as I would expect a numeric sort to be used):

[64, 128, 4].sort() => [128, 4, 64]

https://dxr.mozilla.org/mozilla-central/rev/b3ec8a3373e8faca26c39e9ff577a2d4f8b6927a/devtools/client/performance/modules/categories.js#94

Note the `+mask` to cast to a Number from a String before sorting.

This may not matter in practice since I only see one mask per category at the moment but I noticed it while looking for this pattern or problem.
Summary: bitmasksForCategory for [CATEGORY_MASK is using a string sort on Numbers → bitmasksForCategory for CATEGORY_MASK is using a string sort on Numbers
Priority: -- → P3
Product: Firefox → DevTools

Now that we replaced the old performance panel by the Firefox Profiler (see Bug 1668219) we're closing bugs related to this. If you see similar issues on the new profiler, please file another bug, and we'll be happy to have a look.

Filter on MASSCLOSEOLDPERFTOOLBUGS.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.