Closed
Bug 1299873
Opened 8 years ago
Closed 8 years ago
Typo in nsMsgThreadDBView setting view flags
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 51.0
People
(Reporter: rkent, Assigned: rkent)
Details
Attachments
(1 file)
1.03 KB,
patch
|
alta88
:
review+
|
Details | Diff | Splinter Review |
While reviewing bug 1266698, I came across the following code in nsMsgThreadedDBView.cpp: m_viewFlags |= nsMsgViewFlagsType::kThreadedDisplay; m_viewFlags &= nsMsgViewFlagsType::kGroupBySort; That seems to be an obvious typo. Other occurrences have the expected: m_viewFlags |= nsMsgViewFlagsType::kThreadedDisplay; m_viewFlags &= ~nsMsgViewFlagsType::kGroupBySort;
Assignee | ||
Comment 1•8 years ago
|
||
I don't really understand the possible ramifications of this typo, but the code as written makes no sense.
Comment on attachment 8787312 [details] [diff] [review] The fix Although it's possible to sort so that all root threads with children will be listed ahead of threads with no children (only if mailnews.thread_pane_column_unthreads is false; default is true), attempting to then Group By will change the sortType to byDate. Likely no ramifications, but kGroupBySort flag should indeed be cleared.
Attachment #8787312 -
Flags: review?(alta88) → review+
Assignee | ||
Comment 3•8 years ago
|
||
http://hg.mozilla.org/comm-central/rev/fe75fb786584
Severity: normal → minor
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
You need to log in
before you can comment on or make changes to this bug.
Description
•