1299925 - Handle back button correctly in custom tabs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Dylan Roeh (:droeh) (he/him)]

Currently, when in a custom tab, pressing the back button will close the active tab but leave the CustomTabsActivity running. Correct behavior is probably to call finish().

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Back button support

Just a quick and simple patch for this that finishes the activity and does nothing else when the back button is pressed in a custom tab. There are probably other considerations here (eg: do we close the tab? do we allow the back button to be used for navigation?), but I think we should land this ASAP and figure those issues out later. Without this patch it is impossible to return to an app that has launched a custom tab.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8787408 [details] [diff] [review]
Back button support

Review of attachment 8787408 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good. Please file followups for the other questions you mentioned (or just one bug for 'figure out back button behavior')

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdf79acb0726
Override onBackPressed in CustomTabsActivity to finish the activity. r=snorp

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bdf79acb0726