Closed
Bug 1300005
Opened 8 years ago
Closed 8 years ago
Geolocation::GetCurrentPosition leaks when there are too many pending requests
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
The "options" arg is just allocated by callers, and doesn't get freed if we take the early return before creating the nsGeolocationRequest.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8787495 -
Flags: review?(kchen)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8787495 [details] [diff] [review] Make sure that our PositionOptions structs are always owned by someone in geolocation code Review of attachment 8787495 [details] [diff] [review]: ----------------------------------------------------------------- I think now UniquePtr is preferred over nsAutoPtr. Feel free to leave it as is, I can change it in followups.
Attachment #8787495 -
Flags: review?(kchen) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/275ec9b898aa Make sure that our PositionOptions structs are always owned by someone in geolocation code. r=kanru
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/275ec9b898aa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•