Closed Bug 1300007 Opened 8 years ago Closed 8 years ago

Don't close a stream in an assertion

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox49 --- wontfix
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file, 1 obsolete file)

Don't close a stream in an assertion
1012 bytes, patch
n.nethercote
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta-
Details | Diff | Splinter Review 
Because assertions disappear in non-debug builds.

        Attachment #8787490 -
        Flags: review?(amarchesini)

        Attachment #8787490 -
        Flags: review?(amarchesini) → review+

    
    

    
  


  
New version that (a) compiles in opt builds, and (b) doesn't depend on another
patch in my queue, which means it will backport more easily.

    
  

        Attachment #8787490 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8787519 [details] [diff] [review]
Don't close a stream in an assertion

Review of attachment 8787519 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over r+.

        Attachment #8787519 -
        Flags: review+

    
    

    
  
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6246f5ede4a
Don't close a stream in an assertion. r=baku.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d6246f5ede4a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox51:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

    
    

    
  
Comment on attachment 8787519 [details] [diff] [review]
Don't close a stream in an assertion

Approval Request Comment

[Feature/regressing bug #]: bug 994190 introduced the bug.

[User impact if declined]: Files failing to be closed when they should, causing file descriptors to be leaked. It might also cause memory leaks in some cases, but I'm not certain about that.

[Describe test coverage new/current, TreeHerder]: the line of code in question runs in debug builds. It is unintentionally excluded in non-debug builds.

[Risks and why]: Extremely low. It affects a single function call, and only changes behaviour in non-debug builds.

[String/UUID change made/needed]: none.

        Attachment #8787519 -
        Flags: approval-mozilla-beta?

        Attachment #8787519 -
        Flags: approval-mozilla-aurora?

    
    

    
  
If I understand correctly, this is clearly not a recent regression. As we are super late in the 49 cycle, I would rather see that rides the train with 50

          status-firefox49:
          --- → wontfix

          status-firefox50:
          --- → affected

        Attachment #8787519 -
        Flags: approval-mozilla-beta?

        Attachment #8787519 -
        Flags: approval-mozilla-beta-

        Attachment #8787519 -
        Flags: approval-mozilla-aurora?

        Attachment #8787519 -
        Flags: approval-mozilla-aurora+
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: