Closed
Bug 13004
Opened 25 years ago
Closed 23 years ago
nsDOMEventsIIDs.cpp/.h should go
Categories
(Core :: XPCOM, defect, P3)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla0.9.5
People
(Reporter: mikepinkerton, Assigned: jag+mozilla)
Details
Attachments
(1 file)
7.70 KB,
patch
|
Details | Diff | Splinter Review |
nsDOMEventIIDs.cpp/.h should go. All it does is waste static data space. All of these iid's can be accessed through the GetIID methods.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 1•25 years ago
|
||
Actually, the preferred way is nsCOMTypeInfo<T>.GetIID(), called via the NS_GET_IID(T) macro, I believe. Hey scc, if this is right, should vidur or I go ahead and whack the DOM code? Vidur, you want dibs as you're in there now doing exceptions? (Pink gives me bugs all the time, I think he likes me!) /be
Reporter | ||
Comment 2•25 years ago
|
||
naw, it's not that i like you, i just know you're good at rote global search and replace ;) ;)
Comment 3•25 years ago
|
||
Yes, use |NS_GET_IID(T)|. It is short for |nsCOMTypeInfo<T>::GetIID()|.
Comment 4•25 years ago
|
||
http://lxr.mozilla.org/mozilla/find?string=IIDs finds stuff, I'll fix it all. /be
Comment 5•25 years ago
|
||
No DOM code needs to be whacked from what I can see - the IIDs in layout were defined by joki, I think. Taking myself off of this one.
Updated•25 years ago
|
Target Milestone: M11
Comment 6•25 years ago
|
||
I'll look at this soon. /be
Updated•25 years ago
|
Target Milestone: M11 → M14
Updated•25 years ago
|
Target Milestone: M14 → M15
Comment 7•25 years ago
|
||
I lied, I'll look at this later. Or let scc take it, if he's on a mission from god to clean up all such wastes. /be
Comment 8•24 years ago
|
||
Argh, not gonna happen by tomorrow -- pushing to M16. /be
Target Milestone: M15 → M16
Comment 10•24 years ago
|
||
Moving out, milestone 20 will become a better Mozilla milestone soon. /be
Target Milestone: M18 → M20
Updated•24 years ago
|
Target Milestone: M20 → mozilla0.9
Updated•24 years ago
|
Keywords: mozilla1.0
Comment 11•24 years ago
|
||
dp is no longer @netscape.com. changing qa contact to default for this product
QA Contact: dp → kandrot
Updated•23 years ago
|
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Comment 14•23 years ago
|
||
Does anyone care? Or should I WONTFIX this? /be
Summary: nsDOMEventIIDs.cpp/.h should go → nsDOMEventsIIDs.cpp/.h should go
Target Milestone: mozilla0.9.3 → mozilla0.9.5
Comment 15•23 years ago
|
||
Yeah, let's get rid of it. cc'ing jag & jst.
Comment 16•23 years ago
|
||
Comment 17•23 years ago
|
||
The attached patch gets rid of the nsDOMEventsIIDs.* files and at the same time makes us not compile dlldeps.cpp (since it's not needed any more), this still needs some mac build system help before checking in.
Comment 18•23 years ago
|
||
waterson told me too -- plus, I know jag wants it! (THANKS!) /be
Assignee: brendan → jaggernaut
Status: ASSIGNED → NEW
Assignee | ||
Comment 19•23 years ago
|
||
Wheeeeeeeeeeeeee! r=jag. Thanks jst :-) So who's gonna be the proud sr= giver?
Comment 20•23 years ago
|
||
sr=brendan@mozilla.org if you keep the Mac happy, too. /be
Assignee | ||
Comment 21•23 years ago
|
||
Checked in, marking fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•