1300675 - Harden PVideoDecoder against process crashes

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Matt Woodrow (:mattwoodrow)]

We want to be able to handle crashes of either the GPU process, or the child process without crashing the other.

If it's the GPU process that crashes, we want to resume decoding as soon as it's available again, probably from the next keyframe.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: (lazily) Rebuild VideoDecoderManager when we restart the GPU process

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: (lazily) Rebuild VideoDecoderManager when we restart the GPU process

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: (lazily) Rebuild VideoDecoderManager when we restart the GPU process v3

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8806567 [details] [diff] [review]
(lazily) Rebuild VideoDecoderManager when we restart the GPU process v3

Review of attachment 8806567 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/ipc/VideoDecoderManagerChild.cpp
@@ +84,5 @@
> +    RefPtr<VideoDecoderManagerChild> manager;
> +    RefPtr<Runnable> createManager = NS_NewRunnableFunction([&]() {
> +      Endpoint<PVideoDecoderManagerChild> endpoint;
> +      if (!ContentChild::GetSingleton()->SendInitVideoDecoderManager(&endpoint)) {
> +        return;

return nullptr? (below too)

slightly better form to have this function return RefPtr<VideoDecoderManagerChild>, but okay either way now that sDecoderManager is single-thread.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c13ed43a9cc2
Rebuild VideoDecoderManager when we restart the GPU process. r=dvander

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c13ed43a9cc2