Closed
Bug 1300816
Opened 8 years ago
Closed 8 years ago
Remove nsTimeout::mPrincipal
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
Details
Attachments
(1 file)
|
3.26 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
This seems to not be used for anything any more.
|
Reporter | |
Comment 1•8 years ago
|
||
This seems to not be used for anything any more.
Attachment #8788549 -
Flags: review?(bzbarsky)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8788549 [details] [diff] [review] Remove nsTimeout::mPrincipal r=me. This used to be used for string setTimeout stuff. But we started just using the principal of the window itself in bug 824864, which makes sense. Given that we don't allow cross-origin setTimeout calls, this seems fine. The interaction with document.domain is subtly different, but I don't think anyone cares.
Attachment #8788549 -
Flags: review?(bzbarsky) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9f7f3b88d969 Remove nsTimeout::mPrincipal; r=bzbarsky
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9f7f3b88d969
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
Assignee | |
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•