1301285 - [gtk3] GTK_CSD=1 not generating client side decorations on FF

Status: RESOLVED DUPLICATE of bug 1283299

(Core :: Widget: Gtk, enhancement, P4)

Description

[je-vv]

Attachment: midori_gtk3_csd.gif

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160824215626

Steps to reproduce:

Being using FF 48.0.2 on Arch, compiled against gtk3, I was expecting by setting GTK_CSD=1 to get a FF without a title bar, and with minimize, maximize and close buttons inside FF (right upper corner but within FF) rather than the buttons in the title bar which shouldn't show up any more...

The attached file midori_gtk3_csd.gif shows a similar gtk3 application with CSD working...


Actual results:

Well, the title bar is there (didn't go away), and the min/max/close buttons are not inside FF but rather in the title bar.

Comment 1

[je-vv]

Attachment: ff_gtk3_csd.gif

Comment 2

[je-vv]

The attached ff_gtke_csd.gif shows how actually FF doesn't work as expected with GTK_CSD=1, including the title bar, and having the min/max/close buttons in it, rather than FF itself...

Comment 3

[Hussam Al-Tayeb]

I could be wrong but GTK_CSD=1 doesn't magically create a CSD interface.
It doesn't do anything for applications not using CSD to begin with (evolution, firefox, libreoffice, etc...)

Comment 4

[je-vv]

Well, it's supposed to remove the title bar AFAIK:

https://wiki.archlinux.org/index.php/GTK%2B#Client-side_decorations
https://blogs.gnome.org/mclasen/2013/12/05/client-side-decorations-in-themes

And several applications like midori, gnome-mpv, and others are taking advantage of that...  To me it sounds like the expected behavior is to remove the title bar.  The minimize/maximize/close buttons are expected to be included by the application itself, which is what client side decorations means any ways, or at least I thought it meant...  BTW, FF is already doing that on its ms-windows version.

And supposedly by setting GTK_CSD=1 one is indicating to gtk3 based applications that one is expecting client side decorations to be used by them, :-)

Comment 5

[Karl Tomlinson (:karlt)]

The title and the description of this report are describing different things.

With GTK_CSD=1, the GTK in client app (instead of the window manager) draws the title bar with buttons.  If it is doing this well then you won't notice the difference, but typically you do because the client doesn't respond to mouse input like the window manager does.  e.g. as with Matthias indicates with Ambiance, the window can't be resized or moved from the border.

What the description is requesting is that the client draw something quite different to what the window manager would draw.

I suspect this will be resolved through changes proposed in bug 1283299.

Comment 6

[Hussam Al-Tayeb]

(In reply to Karl Tomlinson (:karlt) from comment #5)
> With GTK_CSD=1, the GTK in client app (instead of the window manager) draws
> the title bar with buttons.  If it is doing this well then you won't notice
> the difference
In this case, this probably works. GTK+ draws deeper shadows arounds the borders than mutter does.
With GTK_CSD=1 firefox, I actually see deeper shadows.