1301333 - [Static Analysis][Clang-Plugin] Mark functions that initialize member variables for their parent class

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

As many of the member variables are not initialised in their constructor and in functions like Init(), we want to mark this type of function that our static analysis tool can check.

On this bug there will be posted patches of this kind.

Comment 1

[Andi [:andi]]

Attachment: mark Init as initialisation function for EventSource

MozReview-Commit-ID: Ef8oHnmrZM8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7697db0f0887
mark Init as initialisation function for EventSource. r=baku

Comment 3

[Andi [:andi]]

Comment on attachment 8789298 [details] [diff] [review]
mark Init as initialisation function for EventSource

https://hg.mozilla.org/integration/mozilla-inbound/rev/7697db0f0887

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7697db0f0887

Comment 5

[Andi [:andi]]

Attachment: Bug 1301333 - mark Initialize as initialisation function for CycleCollectedJSContext.

Review commit: https://reviewboard.mozilla.org/r/79208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79208/

Comment 6

[Andi [:andi]]

Attachment: mark XPCJSContext::Initialize as initialisation function for XPCJSContext

MozReview-Commit-ID: HYj244xg1VD

Comment 7

[Andi [:andi]]

Attachment: mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread

MozReview-Commit-ID: 4mveFlHumVE

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8791959 [details] [diff] [review]
mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread

Review of attachment 8791959 [details] [diff] [review]:
-----------------------------------------------------------------

Can we just omit the #ifdef and mark the function unconditionally?

Comment 9

[Andi [:andi]]

Attachment: mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread

MozReview-Commit-ID: 4mveFlHumVE

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/caa8a9c7d122
mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread. r=jrmuizel

Comment 11

[Andrew McCreight [:mccr8]]

Comment on attachment 8791933 [details]
Bug 1301333 - mark Initialize as initialisation function for CycleCollectedJSContext.

https://reviewboard.mozilla.org/r/79208/#review77824

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/caa8a9c7d122

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9db96226c0c
mark Initialize as initialisation function for CycleCollectedJSContext. r=mccr8

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cf09a35f529
mark XPCJSContext::Initialize as initialisation function for XPCJSContext. r=bobbyholley

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f9db96226c0c

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6cf09a35f529

Comment 17

[Andi [:andi]]

Attachment: mark InitIPDL as initialisation function for VideoDecoderChild

MozReview-Commit-ID: 7xkkoS5Q7t

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f0cf0441dd
mark InitIPDL as initialisation function for VideoDecoderChild. r=cpearce

Comment 19

[Andi [:andi]]

Comment on attachment 8795265 [details] [diff] [review]
mark InitIPDL as initialisation function for VideoDecoderChild

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f0cf0441dd

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6f0cf0441dd

Comment 21

[Andi [:andi]]

Attachment: Add mark-initialisation-func annotation to function Init from PresentationReceiver

MozReview-Commit-ID: JNCBpgHjhs1

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50d3ed5433af
Add mark-initialisation-func annotation to function Init from PresentationReceiver. r=baku

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/50d3ed5433af

Comment 24

[Andi [:andi]]

Attachment: Add mark-initialisation-func annotation to functions Init and DoInitOnMainThread from GetUsageOp

MozReview-Commit-ID: KKUX4FE0pth

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bc34a1ebba2
Add mark-initialisation-func annotation to functions Init and DoInitOnMainThread from GetUsageOp. r=baku

Comment 26

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5bc34a1ebba2

Comment 27

[Andi [:andi]]

Attachment: mark init as initialisation function for ModuleCharsForStore

MozReview-Commit-ID: 4qsINKxyACT

Comment 28

[Jason Orendorff [:jorendorff]]

Comment on attachment 8818206 [details] [diff] [review]
mark init as initialisation function for ModuleCharsForStore

Fell off my radar, but this still applies and can land.

Comment 29

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:andi, maybe it's time to close this bug?

Comment 30

[Andi [:andi]]

We should close this, since these have already been integrated.