Closed
Bug 130137
Opened 22 years ago
Closed 22 years ago
js_AddNativeProperty&js_ChangeNativePropertyAttrs fail to lock obj!
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: brendan, Assigned: brendan)
References
Details
Attachments
(1 file)
2.05 KB,
patch
|
jband_mozilla
:
review+
shaver
:
superreview+
roc
:
approval+
|
Details | Diff | Splinter Review |
This is a stupid oversight on my part. These functions wrap js_AddScopeProperty and js_ChangeScopePropertyAttributes, calling js_GetMutableScope first to ensure that obj has its own scope. They utterly fail to follow the locking protocol and do what other such layers in jsobj.c on top of jsscope.c functions must do. Patch in a second, this is a must-fix for 1.0. /be
Assignee | ||
Comment 1•22 years ago
|
||
Thanks to chingfa for reporting this bug so quickly. Looking for r= and sr= from my bug 62164 patch-buddies. /be
Comment on attachment 73588 [details] [diff] [review] proposed fix sr=shaver.
Attachment #73588 -
Flags: superreview+
Assignee | ||
Comment 3•22 years ago
|
||
*** Bug 130138 has been marked as a duplicate of this bug. ***
Comment 4•22 years ago
|
||
Comment on attachment 73588 [details] [diff] [review] proposed fix r=jband. Looks right to me.
Attachment #73588 -
Flags: review+
Comment on attachment 73588 [details] [diff] [review] proposed fix a=roc+moz
Attachment #73588 -
Flags: approval+
Assignee | ||
Comment 6•22 years ago
|
||
Fixed. Whew! Thanks again to Chingfa. /be
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•