1301887 - File::Slurp triggers warnings on perl 5.24 and it is recommended to not use it

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

See http://blogs.perl.org/users/leon_timmermans/2015/08/fileslurp-is-broken-and-wrong.html

We could use Leon's replacement, or we could just do file IO natively.

Comment 1

[GitHub Autolander Bot]

Attachment: [bugzilla] dylanwh:bug-1301887 > bugzilla:master

Comment 3

[Matt Tyson]

Comment on attachment 8790043 [details] [review]
[bugzilla] dylanwh:bug-1301887 > bugzilla:master

Looks good to me.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

This will continue being a warning reported for users of the 5.x branch.
I know we generally don't backport new features, or add new dependencies to old releases,
but in this case it 1) removes a rather annoying warning message that happens during every request and 2) removes a dependency.
Should we backport this to the 5.0 branch?

Setting approval5.0? and asking gerv to make the call on this.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

To github.com:bugzilla/bugzilla.git
   31651c9..df46774  master -> master

Leaving open pending gerv's call on merging this into 5.0 too

Comment 6

[Gervase Markham [:gerv]]

Changing dependencies, I'd be nervous about. Removing them seems no problem. Well done for taking that path. Let's merge into 5.0.

Gerv

Comment 7

[GitHub Autolander Bot]

Attachment: [bugzilla] dylanwh:bug-1301887-5.0 > bugzilla:5.0

Comment 8

[Gervase Markham [:gerv]]

Comment on attachment 8817745 [details] [review]
[bugzilla] dylanwh:bug-1301887-5.0 > bugzilla:5.0

r- - see Github.

Gerv

Comment 9

[Robin H. Johnson [:robbat2]]

There's a problem with this patch that cropped up in Gentoo's usage.

File::Slurp write_file defaults the umask to 0666, and mktemp uses a much more restrictive umask.
This is exposed by data/assets/ css files being written out without being readable by group.

Comment 10

[Robin H. Johnson [:robbat2]]

Here's the extra fix applied in Gentoo's bugzilla:
https://gitweb.gentoo.org/proj/gentoo-bugzilla.git/commit/?id=ca7bfc9c485c959fad2aee1f7c1dbc0fb484553b

Comment 11

[GitHub Autolander Bot]

Attachment: [bugzilla] vvb16:5.0 > bugzilla:5.0