1302320 - add a test to confirm that video control show "noaudio" icon when video has no audio

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Ray Lin[:ralin]]

We should add a test to chek video UI when video has no audio. The test need to confirm that "noaudio" show up, in other hand, mute/unmute button and volume control are hidden.

Comment 1

[Ray Lin[:ralin]]

Attachment: Bug 1302320 - add noaudio icon test for video control.

Review commit: https://reviewboard.mozilla.org/r/85832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85832/

Comment 2

[Ray Lin[:ralin]]

temporarily hold from review for bug 1271765

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8801023 [details]
Bug 1302320 - add noaudio icon test for video control.

https://reviewboard.mozilla.org/r/85832/#review84980

::: toolkit/content/tests/widgets/mochitest.ini:7
(Diff revision 1)
>  skip-if = buildapp == 'mulet' || buildapp == 'b2g'
>  support-files =
>    audio.wav
>    audio.ogg
>    seek_with_sound.ogg
> +  video.ogg

What's the size of the video file? Did you |git add| it? Can we reuse /mozilla-central/source/browser/base/content/test/general/video.ogg ?

Comment 4

[Ray Lin[:ralin]]

The file is existed on repo alreay, I didn't do |git add| here. It looks like this file has never been used since 2008(first added).

Comment 5

[Ray Lin[:ralin]]

Comment on attachment 8801023 [details]
Bug 1302320 - add noaudio icon test for video control.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85832/diff/1-2/

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8801023 [details]
Bug 1302320 - add noaudio icon test for video control.

https://reviewboard.mozilla.org/r/85832/#review94996

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84fee6da47a6
add noaudio icon test for video control. r=jaws

Comment 8

[Iris Hsiao [:ihsiao]]

sorry had to backout for test_videocontrols_video_noaudio.html assertion failure, https://treeherder.mozilla.org/logviewer.html#?job_id=7078899&repo=autoland#L2408

Comment 9

[Ray Lin[:ralin]]

Thank you Iris, I'll go fix it or maybe consider excluding this test from Android.

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ea8de32a32a
Backed out changeset 84fee6da47a6 for test_videocontrols_video_noaudio.html assertion failure

Comment 11

[Ray Lin[:ralin]]

Comment on attachment 8801023 [details]
Bug 1302320 - add noaudio icon test for video control.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85832/diff/2-3/

Comment 12

[Ray Lin[:ralin]]

Skipped this test on Android platform due to mobile video control doesn't care about `noaudio` state.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e27de747d61
add noaudio icon test for video control. r=jaws

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e27de747d61