1302591 - Fix compile Wmaybe-uninitialized warning on WebVTTListener.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[James Cheng[:JamesCheng]]

Try fix 
warning: 'cue' may be used uninitialized in this function [-Wmaybe-uninitialized]

Even the logic will check the rv without dereferencing the uninitialized pointer, having a initial value is a good.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1302591 - Fix compile Wmaybe-uninitialized warning on WebVTTListener.cpp.

Review commit: https://reviewboard.mozilla.org/r/78592/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78592/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8791033 [details]
Bug 1302591 - Fix compile Wmaybe-uninitialized warning on WebVTTListener.cpp.

https://reviewboard.mozilla.org/r/78592/#review77344

Thanks!

::: dom/media/WebVTTListener.cpp:165
(Diff revision 1)
>      return NS_ERROR_FAILURE;
>    }
>  
> -  TextTrackCue* cue;
> +  TextTrackCue* cue = nullptr;
>    nsresult rv = UNWRAP_OBJECT(VTTCue, &aCue.toObject(), cue);
>    NS_ENSURE_SUCCESS(rv, rv);

Right, the current implementation of UnwrapObject only returns NS_OK after setting cue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c708062f870
Fix compile Wmaybe-uninitialized warning on WebVTTListener.cpp. r=rillian

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1c708062f870