1302922 - "Refresh driver waiting for the compositor for N seconds" logging is missing a space before seconds value

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

Just noticed this being logged to my terminal (by Nightly), when my system was under a decent amount of load:

{
[GFX1-]: Refresh driver waiting for the compositor for2.35138 seconds.
[GFX1-]: Refresh driver waiting for the compositor for1.1841 seconds.
[GFX1-]: Refresh driver waiting for the compositor for5.95352 seconds.
}

(Incidentally, this was at the front page of https://www.goldstar.com/ in a fresh profile on Linux)

As you can see, we're missing a space between "for" and the number of seconds there.  This is obviously a typo in the logging code -- I'm filing this bug on fixing that. Fix coming up.

(This logging was just landed a day ago in bug 1298085, it looks like -- marking this as blocking that bug.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1302922: Add missing space in new "Refresh driver waiting" logging.

Review commit: https://reviewboard.mozilla.org/r/78880/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78880/

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8791462 [details]
Bug 1302922: Add missing space in new "Refresh driver waiting" logging.

https://reviewboard.mozilla.org/r/78880/#review77522

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e699b5ad321
Add missing space in new "Refresh driver waiting" logging. r=nical

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6e699b5ad321