Closed
Bug 1303760
Opened 8 years ago
Closed 6 years ago
Bad capitalization in SuperSearch facet tabs
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: peterbe, Unassigned, Mentored)
Details
Attachments
(1 file)
237.92 KB,
image/png
|
Details |
The capitalization of certain fields look weird. For example the "name" might be "cpu_info" but it's displayed as "Cpu info" as if "cpu" is regular word. It ought to be "CPU Info" or "CPU info".
Reporter | ||
Comment 1•8 years ago
|
||
I'm assuming the labels for the tabs are made something like this: `name.replace('_', ' ').title()`. Can't we just set the Name field in the SuperSearch Fields to "CPU Info"? Or will that mess badly with our select2 drop-downs? And a change like that, what will it mean for people who have saved queries?
Comment 2•8 years ago
|
||
If you change the `name` field, you change the API. That is something we should refrain from doing. The field's name is `cpu_info`, and I don't know how we could turn that into `CPU info` in any trivial way. I honestly don't think we should care about such a cosmetic thing, but if you really want to change that, I suppose you could simply remove the `| capitalize` rule here: https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/supersearch/jinja2/supersearch/search_results.html#L79
Reporter | ||
Comment 3•8 years ago
|
||
We could attack that by having a list of keywords that should be all upper case. Like "CPU", "VM", "OS", etc. We should do the same with the drop-down choices too. So it becomes "Adapter device ID" instead of "adapter device id". But if you think this is not important, feel free to close this bug.
Comment 4•8 years ago
|
||
I feel this is not important enough for me to work on this, but it looks like a good first bug for someone looking to contribute to Socorro.
Mentor: adrian
Comment 5•6 years ago
|
||
I see the problem, but have no interest in fixing this or dealing with maintaining the machinations required to fix this. If I had my druthers, we'd lowercase everything. I'm going to mark this WONTFIX.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•