1304336 - Remove MediaDecoderStateMachine::mLogicalPlaybackRate

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per http://searchfox.org/mozilla-central/rev/dbbbafc979a8362a1c8e3e99dbea188fc832b1c5/dom/media/MediaDecoderStateMachine.h#928.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1304336. Part 1 - call DispatchSetPlaybackRate() to propagate playback rate changes instead of using a mirror.

Review commit: https://reviewboard.mozilla.org/r/80610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80610/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1304336. Part 2 - remove unused canonical/mirror.

Review commit: https://reviewboard.mozilla.org/r/80612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80612/

Comment 3

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8794032 [details]
Bug 1304336. Part 1 - call DispatchSetPlaybackRate() to propagate playback rate changes instead of using a mirror.

https://reviewboard.mozilla.org/r/80610/#review79602

Comment 4

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8794033 [details]
Bug 1304336. Part 2 - remove unused canonical/mirror.

https://reviewboard.mozilla.org/r/80612/#review79604

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e0816190900
Part 1 - call DispatchSetPlaybackRate() to propagate playback rate changes instead of using a mirror. r=kikuo
https://hg.mozilla.org/integration/autoland/rev/117b804d8324
Part 2 - remove unused canonical/mirror. r=kikuo

Comment 7

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/4e0816190900
https://hg.mozilla.org/mozilla-central/rev/117b804d8324