1304586 - Incorrect whitespace handling when middle-clicking on an "Add this term to the search form" in a crash-stats search

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Nicholas Nethercote [inactive]]

Consider this super search that is faceted on "moz crash reason":

https://crash-stats.mozilla.com/search/?product=Firefox&_sort=-date&_facets=moz_crash_reason&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-moz_crash_reason

There are a few entries where the "moz crash reason" looks like "ElementAt(aIndex = 3, aLength = 3)".

If I left-click on one of those links to perform a narrowing search, I end up at this URL:

https://crash-stats.mozilla.com/search/?moz_crash_reason=%3DElementAt%28aIndex%20%3D%203%2C%20aLength%20%3D%203%29&product=Firefox&_sort=-date&_facets=moz_crash_reason&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-moz_crash_reason

and the search works.

If I instead middle-click on one of those links I end up at a different URL:

https://crash-stats.mozilla.com/search/?moz_crash_reason=%3DElementAt%28aIndex%20&product=Firefox&page=1&_sort=-date&_facets=moz_crash_reason&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform

The "moz crash reason" field has been incorrectly truncated at the first whitespace to "ElementAt(aIndex" and I get no results.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3504

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/2b539a07ccafae7cb2344420d6de458e5832370d
Fixes bug 1304586 - Life is better when it's urlencoded. (#3504)