Closed
Bug 1304779
Opened 8 years ago
Closed 8 years ago
Delete unused dom/indexedDB/ActorsParent.cpp copy constructors
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
References
()
Details
Attachments
(1 file)
When building with GCC 6 and --enable-warnings-as-errors, errors like this are encountered:
> /moz/mozilla-inbound/dom/indexedDB/ActorsParent.cpp:13042:1: error: ‘mozilla::dom::indexedDB::{anonymous}::ConnectionPool::IdleThreadInfo::IdleThreadInfo(const mozilla::dom::indexedDB::{anonymous}::ConnectionPool::IdleThreadInfo&)’ defined but not used [-Werror=unused-function]
These point at various unused copy constructors.
While I would prefer not having to remove them, having to carry a local patch just to get a working build is a bit annoying.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8793833 [details] Bug 1304779 - Delete unused dom/indexedDB/ActorsParent.cpp copy constructors. https://reviewboard.mozilla.org/r/80456/#review79892 r=me
Attachment #8793833 -
Flags: review?(jvarga) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Thanks for the review! https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d10c7341083
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/dad990960ba0 Delete unused dom/indexedDB/ActorsParent.cpp copy constructors. r=janv
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dad990960ba0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•