Closed
Bug 1304781
Opened 8 years ago
Closed 7 years ago
Intermittent test_safe_browsing_initial_download.py TestSafeBrowsingInitialDownload.test_safe_browsing_initial_download | TimeoutException: Timed out after 30.1 seconds with message: Safe Browsing File: ^goog-badbinurl-shavar.pset$ not found!
Categories
(Testing :: Firefox UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla51
People
(Reporter: intermittent-bug-filer, Unassigned)
References
Details
(Keywords: intermittent-failure)
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=3886039&repo=autoland https://queue.taskcluster.net/v1/task/aV-VhMvxRaGsyMXJxXXrjw/runs/0/artifacts/public%2Flogs%2Flive_backing.log
Comment 1•8 years ago
|
||
Downloaded safebrowsing files: ['test-unwanted-simple.pset', 'test-block-simple.pset', 'test-malware-simple.pset', 'test-trackwhite-simple.pset', 'test-track-simple.sbstore', 'test-phish-simple.pset', 'test-phish-simple.sbstore', 'test-trackwhite-simple.sbstore', 'test-malware-simple.sbstore', 'test-track-simple.pset', 'test-unwanted-simple.sbstore', 'test-block-simple.sbstore']
Depends on: 1302958
Comment 2•8 years ago
|
||
Francois, fyi we are failing a lot in this test on Aurora those days mainly on OS X and Windows, but not Linux. It happens across locales. Maybe someone should investigate?
Flags: needinfo?(francois)
Comment 3•8 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #2) > Francois, fyi we are failing a lot in this test on Aurora those days mainly > on OS X and Windows, but not Linux. It happens across locales. > > Maybe someone should investigate? Is it just slow? Depending on the kind of VM and network that these tests run on, it's possible we need to give the tests a minute or two to download the lists.
Flags: needinfo?(francois)
Comment 4•8 years ago
|
||
Matt, would you be able to confirm that Safe Browsing is working in Aurora on OSX and Windows, just in case? I'm thinking: 1. creating a new profile 2. checking that the list files have been downloaded to the cache directory (~/Library/Caches/Firefox/Profiles/XXXX/safebrowsing/ and C:\Users\XXXX\AppData\Local\mozilla\firefox\profiles\XXXX\safebrowsing\) after a few minutes 3. checking the Webpage Warnings links on https://testsafebrowsing.appspot.com/ after a few hours
Flags: needinfo?(mwobensmith)
Comment hidden (Intermittent Failures Robot) |
Comment 6•8 years ago
|
||
(In reply to François Marier [:francois] from comment #3) > (In reply to Henrik Skupin (:whimboo) from comment #2) > Is it just slow? Depending on the kind of VM and network that these tests > run on, it's possible we need to give the tests a minute or two to download > the lists. It's hard to tell without the changes from bug 1304983. Should we maybe backport this addition to aurora?
Comment 7•8 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #6) > It's hard to tell without the changes from bug 1304983. Should we maybe > backport this addition to aurora? Right, I had forgotten that the test on Aurora was different from the one in Nightly. I think it makes sense to uplift given that this test has caused problems in the past.
Comment 8•8 years ago
|
||
Ok, I requested the uplift of the changes. It will also mean we won't hit a failure signature like this one anymore once landed. Once we see a similar bug I will duplicate it accordingly. Maybe its related to bug 1309764.
Comment 9•8 years ago
|
||
Francois, on mozilla-aurora the first failures clearly started between those two nightly builds: https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=41593448b1ae&tochange=fb564edbd98d Not sure what this "Automated HSTS preload list update" is, but maybe it is related? I will try to retrigger some tests from before those changes to see if those tests are still green. If not we might see a remote change by Google?
Comment 10•8 years ago
|
||
Most of the newly triggered tests are failing: https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=6eefe948a169&filter-searchStr=os%20x%20firefox%20ui&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=3856149 So I would expect a change on the remote site around this time.
Comment 11•8 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #9) > Not sure what this "Automated HSTS preload list update" is, but maybe it is > related? I will try to retrigger some tests from before those changes to see > if those tests are still green. Interesting. The HSTS preload list is not delivered through Safe Browsing. I would guess it's delivered by Kinto. Maybe it affects the timing of other downloads that happen at startup time? Would disabling network.stricttransportsecurity.preloadlist actually change anything? > If not we might see a remote change by Google? If that were the case then we'd see manual tests also fail. Hopefully Matt can confirm that this is not happening.
Comment 12•8 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #9) > https://hg.mozilla.org/releases/mozilla-aurora/ > pushloghtml?fromchange=41593448b1ae&tochange=fb564edbd98d > > Not sure what this "Automated HSTS preload list update" is, but maybe it is > related? Oh, I was wrong. This isn't about letting kinto ship HPKP/HSTS lists to Firefox, but rather about doing a sync of the Google list. Nothing in that pushlog seems related to the timeouts we're seeing.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 15•8 years ago
|
||
Using steps from comment 4, I see no issues with today's Aurora 51.0a2, on Windows 10 and Mac OSX. As always, the updates take several hours, but eventually the sites are blocked.
Flags: needinfo?(mwobensmith)
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: bulk-close-intermittents
Resolution: --- → INCOMPLETE
Comment 16•7 years ago
|
||
Fixed by bug 1304983 for Firefox 51.0.
Resolution: INCOMPLETE → FIXED
Target Milestone: --- → mozilla51
Updated•7 years ago
|
Keywords: bulk-close-intermittents
You need to log in
before you can comment on or make changes to this bug.
Description
•