Closed
Bug 1304999
Opened 8 years ago
Closed 8 years ago
Crash in mozilla::layers::AttemptVideoScale
Categories
(Core :: Graphics: Layers, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: philipp, Assigned: sotaro, NeedInfo)
References
Details
(Keywords: crash, regression, Whiteboard: [gfx-noted])
Crash Data
Attachments
(2 files, 1 obsolete file)
1.25 KB,
patch
|
jrmuizel
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
1.14 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-1d61ae89-21d0-4711-be1b-851742160923. ============================================================= Crashing Thread (21) Frame Module Signature Source 0 xul.dll mozilla::layers::AttemptVideoScale gfx/layers/basic/BasicCompositor.cpp:445 1 xul.dll mozilla::layers::BasicCompositor::DrawQuad(mozilla::gfx::RectTyped<mozilla::gfx::UnknownUnits, float> const&, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, mozilla::layers::EffectChain const&, float, mozilla::gfx::Matrix4x4Typed<mozilla::gfx::UnknownUnits, mozilla::gfx::UnknownUnits> const&, mozilla::gfx::RectTyped<mozilla::gfx::UnknownUnits, float> const&) gfx/layers/basic/BasicCompositor.cpp:555 2 @0x13 3 xul.dll mozilla::layers::RenderLayers<mozilla::layers::ContainerLayerComposite>(mozilla::layers::ContainerLayerComposite*, mozilla::layers::LayerManagerComposite*, mozilla::gfx::IntRectTyped<mozilla::RenderTargetPixel> const&) gfx/layers/composite/ContainerLayerComposite.cpp:627 4 xul.dll mozilla::layers::RenderIntermediate<mozilla::layers::ContainerLayerComposite>(mozilla::layers::ContainerLayerComposite*, mozilla::layers::LayerManagerComposite*, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, RefPtr<mozilla::layers::CompositingRenderTarget>) gfx/layers/composite/ContainerLayerComposite.cpp:736 5 xul.dll mozilla::layers::ContainerPrepare<mozilla::layers::ContainerLayerComposite>(mozilla::layers::ContainerLayerComposite*, mozilla::layers::LayerManagerComposite*, mozilla::gfx::IntRectTyped<mozilla::RenderTargetPixel> const&) gfx/layers/composite/ContainerLayerComposite.cpp:434 6 xul.dll mozilla::layers::ContainerLayerComposite::Prepare(mozilla::gfx::IntRectTyped<mozilla::RenderTargetPixel> const&) gfx/layers/composite/ContainerLayerComposite.cpp:872 7 xul.dll mozilla::layers::ContainerPrepare<mozilla::layers::ContainerLayerComposite>(mozilla::layers::ContainerLayerComposite*, mozilla::layers::LayerManagerComposite*, mozilla::gfx::IntRectTyped<mozilla::RenderTargetPixel> const&) gfx/layers/composite/ContainerLayerComposite.cpp:401 8 xul.dll mozilla::layers::ContainerLayerComposite::Prepare(mozilla::gfx::IntRectTyped<mozilla::RenderTargetPixel> const&) gfx/layers/composite/ContainerLayerComposite.cpp:872 9 xul.dll mozilla::layers::ContainerPrepare<mozilla::layers::ContainerLayerComposite>(mozilla::layers::ContainerLayerComposite*, mozilla::layers::LayerManagerComposite*, mozilla::gfx::IntRectTyped<mozilla::RenderTargetPixel> const&) gfx/layers/composite/ContainerLayerComposite.cpp:401 10 xul.dll mozilla::layers::ContainerLayerComposite::Prepare(mozilla::gfx::IntRectTyped<mozilla::RenderTargetPixel> const&) gfx/layers/composite/ContainerLayerComposite.cpp:872 11 xul.dll mozilla::layers::LayerManagerComposite::Render(mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&) gfx/layers/composite/LayerManagerComposite.cpp:934 12 xul.dll mozilla::layers::LayerManagerComposite::UpdateAndRender() gfx/layers/composite/LayerManagerComposite.cpp:478 13 xul.dll mozilla::layers::LayerManagerComposite::EndTransaction(mozilla::TimeStamp const&, mozilla::layers::LayerManager::EndTransactionFlags) gfx/layers/composite/LayerManagerComposite.cpp:399 14 xul.dll mozilla::layers::CompositorBridgeParent::CompositeToTarget(mozilla::gfx::DrawTarget*, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const*) gfx/layers/ipc/CompositorBridgeParent.cpp:1260 15 xul.dll mozilla::layers::CompositorVsyncScheduler::ComposeToTarget(mozilla::gfx::DrawTarget*, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const*) gfx/layers/ipc/CompositorBridgeParent.cpp:590 16 xul.dll mozilla::layers::CompositorVsyncScheduler::Composite(mozilla::TimeStamp) gfx/layers/ipc/CompositorBridgeParent.cpp:491 this is a crashing signature on windows appearing to happen within new code-path from bug 1266491 that seems to affect pre-release builds starting beginning with firefox 50 so far. although there has been one single crash with 49.0b1 as well: https://crash-stats.mozilla.com/report/index/e0a609e0-f3dc-4b6c-903d-ca9752160804
Updated•8 years ago
|
Flags: needinfo?(jmuizelaar)
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [gfx-noted]
WrappingTextureSourceYCbCrBasic::GetSurface returns nullptr?
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #1) > WrappingTextureSourceYCbCrBasic::GetSurface returns nullptr? Yea, it seems like nullptr access.
Assignee | ||
Comment 3•8 years ago
|
||
Bug 1254011 seems to affect to the crash. It defer DataSourceSurface allocation and YCbCr color conversion.
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #3) > Bug 1254011 seems to affect to the crash. It defer DataSourceSurface > allocation and YCbCr color conversion. In oom situation, DataSourceSurface allocation could fail.
Assignee | ||
Comment 5•8 years ago
|
||
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8795976 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8795982 -
Flags: review?(jmuizelaar)
Updated•8 years ago
|
Attachment #8795982 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1aa20b6e2482
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4980a2aea6fb Add nullptr check of YCbCr to rgb surface r=jrmuizel
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4980a2aea6fb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 10•8 years ago
|
||
Sotaro, as this is impacting 50 & 51, do you want to uplift that? If yes, could you fill the uplift request? Thanks
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 11•8 years ago
|
||
Flags: needinfo?(sotaro.ikeda.g)
Attachment #8798269 -
Flags: review+
Assignee | ||
Comment 12•8 years ago
|
||
Comment on attachment 8795982 [details] [diff] [review] patch - Add nullptr check of YCbCr to rgb surface Approval Request Comment [Feature/regressing bug #]: bug 1254011 [User impact if declined]: Could cause a crash during out of memory and BasicCompositor(no gpu acceleration). [Describe test coverage new/current, TreeHerder]:Tested locally. [Risks and why]: Low. The patch just add checking of nullptr. [String/UUID change made/needed]: none
Attachment #8795982 -
Flags: approval-mozilla-beta?
Attachment #8795982 -
Flags: approval-mozilla-aurora?
Comment 13•8 years ago
|
||
Comment on attachment 8795982 [details] [diff] [review] patch - Add nullptr check of YCbCr to rgb surface Fix a crash, seems low risk, taking it. Should be 50 beta 5.
Attachment #8795982 -
Flags: approval-mozilla-beta?
Attachment #8795982 -
Flags: approval-mozilla-beta+
Attachment #8795982 -
Flags: approval-mozilla-aurora?
Attachment #8795982 -
Flags: approval-mozilla-aurora+
Comment 14•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/57ad439e58a9
Comment 15•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/37417e763286faffc6d50d93fe0fee3da795dee7
Comment 16•8 years ago
|
||
Crash volume for signature 'mozilla::layers::AttemptVideoScale': - nightly (version 52): 0 crashes from 2016-09-19. - aurora (version 51): 1 crash from 2016-09-19. - beta (version 50): 935 crashes from 2016-09-20. - release (version 49): 1 crash from 2016-09-05. - esr (version 45): 0 crashes from 2016-07-25. Crash volume on the last weeks (Week N is from 10-17 to 10-23): W. N-1 W. N-2 W. N-3 W. N-4 - nightly 0 0 0 0 - aurora 0 0 1 0 - beta 42 410 387 90 - release 1 0 0 0 - esr 0 0 0 0 Affected platform: Windows Crash rank on the last 7 days: Browser Content Plugin - nightly - aurora - beta #869 - release - esr
Assignee | ||
Comment 17•8 years ago
|
||
crash of firefox49 seems to be caused by a different problem. > report 701fd78b-c004-44ef-9710-18bbd2161011 place of crash is different and bug 1254011 fix does not exit in firefox49, only bug 1266491 exists.
Assignee | ||
Comment 18•8 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #17) > crash of firefox49 seems to be caused by a different problem. > > report 701fd78b-c004-44ef-9710-18bbd2161011 https://crash-stats.mozilla.com/report/index/701fd78b-c004-44ef-9710-18bbd2161011
You need to log in
before you can comment on or make changes to this bug.
Description
•