1305346 - [Pointer Events] Make `pointerId` a mandatory parameter when creating Widget Mouse Events and its subclasses.

Status: NEW

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Description

[Ben Hsu [:HoPang]]

Now, we always first create a widget mouse event (and its sub-classes), and then assign the pointerId afterward. In this pattern, we largely rely on the default value to assign the value for us, and it's error-prone.

Since `pointerId` is basically comes from the platform, I suggest we should make `pointerId` a const member in widget mouse event and its sub-classes, and only assign the value on its creation. By doing this, we can make the code way more clear.

Comment 1

[Ben Hsu [:HoPang]]

Here is the WIP patches, where they can be successfully compiled on Windows, Osx, and Linux, and work well on my surface pro. Any comment and suggestion are greatly appreciated :)

https://github.com/driftersprt/gecko-dev/commits/1305346

Comment 2

[Edgar Chen [:edgar]]

Not actively work on this.