1305494 - Android Studio 2.2: Update android gradle plugin to 2.2.2

Status: RESOLVED WONTFIX

(Firefox Build System :: Android Studio and Gradle Integration, defect, P2)

Description

[:Grisha Kruglov]

Now that Android Studio 2.2 is the current stable release version, we need to bump our Gradle plugin version. It uses Gradle 2.14.1, so we should be good on that front (see Bug 1300094).

Note that default ProGuard rules changed in this version, which might or might not affect us. See release notes https://developer.android.com/studio/releases/gradle-plugin.html#revisions and SO bugs e.g. http://stackoverflow.com/questions/39667203/android-gradle-plugin-2-2-0-proguard-began-to-keep-inner-classes

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

The circle of life :)

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=08a2ae25c1fa

Comment 3

[:Grisha Kruglov]

A-S just updated. It is now Android Gradle plugin version 2.2.1.

Comment 4

[:Grisha Kruglov]

A-S just updated. It is now Android Gradle plugin version 2.2.2.

Comment 5

[:Grisha Kruglov]

Android Studio updated to 2.3. It seems that we should finally look at upgrading, those "update" prompts are getting annoying.

Bug 1300094 is a decent starting pointed on how to do this. Requesting tracking to get this into triage.

Comment 6

[Nick Alexander :nalexander [he/him]]

This is "easy", providing everything works.  Uploading to tooltool is the frustrating part, but I think it's documented at https://dxr.mozilla.org/mozilla-central/source/build/docs/toolchains.rst#58.  That might be stale now, however...

Comment 7

[Nick Alexander :nalexander [he/him]]

Per https://github.com/androidannotations/androidannotations/wiki/Building-Project-Gradle, the first version of the Android-Gradle build plugin that supports annotation processors is 2.3.0.  Part of https://bugzilla.mozilla.org/show_bug.cgi?id=1255915#c1 is making the JNI wrapper generation "Gradle friendly".  The long-term approach is to transition to the annotation processing framework, which requires bumping the Android-Gradle build plugin forward.  (The short-term approach might not be to do that work, but instead to figure out how to get Gradle to invoke the annotation processing JAR we currently have with the correct classpath.)

Comment 8

[Nick Alexander :nalexander [he/him]]

This is superseded by https://bugzilla.mozilla.org/show_bug.cgi?id=1366644.