1305850 - Assert failed in checkConstructorArguments(525): !type.isUnsizedArray()

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[Jesse Schwartzentruber (:truber)]

Attachment: testcase.html

The attached testcase causes an assertion in Angle in mozilla-central revision 66a77b9bfe5d.

err: checkConstructorArguments(525): 	! Assert failed in checkConstructorArguments(525): !type.isUnsizedArray()

firefox: /home/worker/workspace/build/src/gfx/angle/src/compiler/translator/ParseContext.cpp:525: bool TParseContext::checkConstructorArguments(const TSourceLoc &, TIntermNode *, const TFunction &, TOperator, const TType &): Assertion `!type.isUnsizedArray()' failed.

Backtrace:

#4  0x00007fffe2685bdc in TParseContext::checkConstructorArguments(TSourceLoc const&, TIntermNode*, TFunction const&, TOperator, TType const&) (this=0x7fffffff2460, line=..., argumentsNode=0x0, function=..., op=EOpConstructVec4, type=...) at /home/worker/workspace/build/src/gfx/angle/src/compiler/translator/ParseContext.cpp:525
#5  0x00007fffe268da02 in TParseContext::addConstructor(TIntermNode*, TOperator, TFunction*, TSourceLoc const&) (this=0x7fffffff2460, arguments=0x0, op=EOpConstructVec4, fnCall=<optimized out>, line=...) at /home/worker/workspace/build/src/gfx/angle/src/compiler/translator/ParseContext.cpp:2298
#6  0x00007fffe2694cac in TParseContext::addFunctionCallOrMethod(TFunction*, TIntermNode*, TIntermNode*, TSourceLoc const&, bool*) (this=0x7fffffff2460, fnCall=0x62500114e5b0, paramNode=0x0, thisNode=0x0, loc=..., fatalError=<optimized out>) at /home/worker/workspace/build/src/gfx/angle/src/compiler/translator/ParseContext.cpp:3980
#7  0x00007fffe25b65f8 in yyparse(TParseContext*, void*) (context=<optimized out>, scanner=0x60f000305bf0) at /home/worker/workspace/build/src/gfx/angle/src/compiler/translator/glslang_tab.cpp:2500
#8  0x00007fffe26957ff in PaParseStrings(unsigned long, char const* const*, int const*, TParseContext*) (count=1, string=0x7fffffff2ce0, length=0x0, context=0x7fffffff2460) at /home/worker/workspace/build/src/gfx/angle/src/compiler/translator/ParseContext.cpp:4146
#9  0x00007fffe25f395a in TCompiler::compileTreeImpl(char const* const*, unsigned long, int) (this=0x6190009aa180, shaderStrings=0x7fffffff2ce0, numStrings=0, compileOptions=16971916) at /home/worker/workspace/build/src/gfx/angle/src/compiler/translator/Compiler.cpp:239
#10 0x00007fffe25f7b3c in TCompiler::compile(char const* const*, unsigned long, int) (this=<optimized out>, shaderStrings=0x7fffffff2ce0, numStrings=<optimized out>, compileOptionsIn=<optimized out>) at /home/worker/workspace/build/src/gfx/angle/src/compiler/translator/Compiler.cpp:426
#11 0x00007fffdf0d2913 in mozilla::webgl::ShaderValidator::ValidateAndTranslate(char const*) (this=<optimized out>, source=0x6040005ad4d8 "void main("...) at /home/worker/workspace/build/src/dom/canvas/WebGLShaderValidator.cpp:215

Comment 1

[Jesse Schwartzentruber (:truber)]

Attachment: log.txt

Comment 2

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This was fixed by the ANGLE update in 1319004. NI myself to land a crashtest.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50c0948e975c
Add crashtest. r=me

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/50c0948e975c