1305892 - [webvr] Support Oculus Touch Haptic Feedback

Status: RESOLVED FIXED

(Core :: WebVR, defect, P3)

Description

[:kip (Kearwood Gilbert)]

Initially we will only support the "pulse()" function as described the in Gamepad API Extension spec.

Later, we could explore benefits of implementing APIs to support buffered haptics as exposed by the Oculus SDK.

Comment 1

[Daosheng Mu[:daoshengmu]]

According Oculus SDK doc, https://developer3.oculus.com/doc/1.10-libovr/_o_v_r___c_a_p_i_8h.html#a4d519fe78e976e31010e0510894276ff,

ovrResult ovr_SetControllerVibration()

Sets constant vibration (with specified frequency and amplitude) to a controller, and vibration lasts for a maximum of 2.5 seconds.

Non-Buffered Haptics
Vibration can be enabled by calling ovr_SetControllerVibration:

ovr_SetControllerVibration( Hmd, ovrControllerType_LTouch, freq, trigger);
Vibration is enabled by specifying the frequency. Specifying 0.0f will vibrate at 160Hz. Specifying 1.0f will vibrate at 320Hz.
frequency. Supported values are: 0.0 (disabled), 0.5 and 1.0. Non valid values will be clamped.

Comment 2

[Daosheng Mu[:daoshengmu]]

I have tried it in a few days but can't get the vibrate response from ovr_SetControllerVibration(). However, the demo from Oculus runs fairly. Probably, I need to check whether the Oculus SDK has been updated totally. Or, Is it only allowed be run at the main thread?

Comment 3

[Daosheng Mu[:daoshengmu]]

(In reply to Daosheng Mu[:daoshengmu] from comment #1)
> According Oculus SDK doc,
> https://developer3.oculus.com/doc/1.10-libovr/_o_v_r___c_a_p_i_8h.
> html#a4d519fe78e976e31010e0510894276ff,
> 
> ovrResult ovr_SetControllerVibration()
> 
> Sets constant vibration (with specified frequency and amplitude) to a
> controller, and vibration lasts for a maximum of 2.5 seconds.
> 
> Non-Buffered Haptics
> Vibration can be enabled by calling ovr_SetControllerVibration:
> 
> ovr_SetControllerVibration( Hmd, ovrControllerType_LTouch, freq, trigger);
> Vibration is enabled by specifying the frequency. Specifying 0.0f will
> vibrate at 160Hz. Specifying 1.0f will vibrate at 320Hz.
> frequency. Supported values are: 0.0 (disabled), 0.5 and 1.0. Non valid
> values will be clamped.

Here mentions "Vibration is enabled by specifying the frequency. Specifying 0.0f will vibrate at 160Hz. Specifying 1.0f will vibrate at 320Hz."

https://developer3.oculus.com/documentation/pcsdk/1.10/concepts/dg-input-touch-haptic/

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1305892 - Support Oculus Touch Haptic Feedback;

Review commit: https://reviewboard.mozilla.org/r/124652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124652/

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8852400 [details]
Bug 1305892 - Support Oculus Touch Haptic Feedback;

https://reviewboard.mozilla.org/r/124652/#review127206

This LGTM.

Comment 6

[Daosheng Mu[:daoshengmu]]

(In reply to Daosheng Mu[:daoshengmu] from comment #2)
> I have tried it in a few days but can't get the vibrate response from
> ovr_SetControllerVibration(). However, the demo from Oculus runs fairly.
> Probably, I need to check whether the Oculus SDK has been updated totally.
> Or, Is it only allowed be run at the main thread?

This is because Oculus only responses the vibration in the presenting mode. It is different from OpenVR vibration. Interesting!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ade262f9655
Support Oculus Touch Haptic Feedback; r=kip

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6ade262f9655