Closed
Bug 130665
Opened 22 years ago
Closed 22 years ago
Replace nsString with nsAString in nsLinebreakConverter::ConvertStringLineBreaks
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: harishd, Assigned: scc)
References
Details
Attachments
(1 file)
2.59 KB,
text/plain
|
Details |
nsLinebreakConverter::ConvertStringLineBreaks() seems to accepting nsString. Could this be changed to nsAString ( or something equivalent ) instead? This blocks bug 111576.
Nominating for nsbeta1 since it blocks bug 111576.
Severity: normal → blocker
Keywords: nsbeta1
After refering to lxr it looks like this bug should belong to sfraser.
Assignee: scc → sfraser
Severity: blocker → normal
Summary: Repleace nsString with nsAString → Replace nsString with nsAString
timeless: Why did you change the severity from blocker to normal. THIS BUG BLOCKS BUG 111576.
Severity: normal → blocker
if it blocks some bug, then use blocks/depends, blocker should be considered severity, and in my opinion this is nearly trivial.
Blocks: 111576
Updated•22 years ago
|
Summary: Replace nsString with nsAString → Replace nsString with nsAString in nsLinebreakConverter::ConvertStringLineBreaks
Comment 5•22 years ago
|
||
Timeless is right. 'Blocker' means that it prevents daily use. And how exactly does this block bug 111576?
Severity: blocker → normal
OS: Windows 2000 → All
Hardware: PC → All
Ok...my bad...my understanding for "blocker" was different. Now I know :)
"Reassign bug to owner and QA contact of selected component"
Assignee: scc → jaggernaut
QA Contact: jaggernaut → scc
Comment 9•22 years ago
|
||
Thanks timeless, but in this case he really meant "reassigning to scc"
Assignee: jaggernaut → scc
QA Contact: scc → jaggernaut
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•22 years ago
|
||
This function can be pasted right into your source near the point where you need it. Still need to double-check if it's OK to directly say '\r' and '\n' or if that gets screwed up under MacOS <= 9. It's fine on Windows, *nix, and MacOS X. Hope this helps
Assignee | ||
Comment 11•22 years ago
|
||
We might want to use some |PR...| type rather than |size_t| in the above patch. Let's talk about it when we paste this function into your _big_ patch.
Assignee | ||
Comment 12•22 years ago
|
||
jag, the string owner, is going to look at the feasibility of replacing the existing line break converter with this function, in which case, he'll end up chopping it out of where ever you put it, and putting it someplace more global
Comment 13•22 years ago
|
||
this patch was checked in at the appropriate spot as part of the fix for bug #111576
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•