Closed
Bug 1306708
Opened 8 years ago
Closed 8 years ago
Rename prio() annotation to nesting; add new prio() annotation
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(2 files)
125.84 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
10.40 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
This will allow us to use prio() for event queue priority, which makes more sense. The nesting annotation can be something like: nesting(inside_sync) // formerly prio(high) or nesting(inside_cpow) // formerly prio(urgent)
Assignee | ||
Comment 1•8 years ago
|
||
This is a pretty straightforward renaming. The only hard part was trying to get English phrases in comments to make sense using the new language. I sort of settled on "nested level" as a replacement for priority. I think "nested" is a little better than "nesting" because it makes it clear that it's about what the message can nest in rather than what can nest inside it. I left space in the message for a priority bit, which will be used in the next patch. In this patch it's always unset.
Attachment #8796772 -
Flags: review?(dvander)
Assignee | ||
Comment 2•8 years ago
|
||
This patch adds a prio() annotation to IPDL that is orthogonal to nested(). Right now it doesn't do anything. In bug 1306591 Thinker is going to use it to post messages to a special event queue that will be processed preferentially.
Attachment #8796773 -
Flags: review?(dvander)
Attachment #8796772 -
Flags: review?(dvander) → review+
Attachment #8796773 -
Flags: review?(dvander) → review+
Pushed by wmccloskey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/649af7cb0c87 Rename prio to nested in IPDL (r=dvander) https://hg.mozilla.org/integration/mozilla-inbound/rev/bd7123b6858c Add prio() for message priority to IPDL (r=dvander)
Pushed by wmccloskey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b4efa44255 Fix rebasing bustage on a CLOSED TREE
Pushed by wmccloskey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9690621e02 Revert "Bug 1306708 - Fix rebasing bustage on a CLOSED TREE" https://hg.mozilla.org/integration/mozilla-inbound/rev/977c8d8ccd4b Revert "Bug 1306708 - Add prio() for message priority to IPDL (r=dvander)" https://hg.mozilla.org/integration/mozilla-inbound/rev/eb29ec2808c1 Revert "Bug 1306708 - Rename prio to nested in IPDL (r=dvander)" on a CLOSED TREE
Pushed by wmccloskey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb124a19fb68 Rename prio to nested in IPDL (r=dvander) https://hg.mozilla.org/integration/mozilla-inbound/rev/507a5967ec1d Add prio() for message priority to IPDL (r=dvander)
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9b9690621e02 https://hg.mozilla.org/mozilla-central/rev/eb29ec2808c1
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9b9690621e02 https://hg.mozilla.org/mozilla-central/rev/eb29ec2808c1
Comment 9•8 years ago
|
||
backout bugherder |
https://hg.mozilla.org/mozilla-central/rev/977c8d8ccd4b
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fb124a19fb68 https://hg.mozilla.org/mozilla-central/rev/507a5967ec1d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•