130691 - [PATCH][PARTIAL]Crash when changing scale while Printing

Status: VERIFIED FIXED

(Core :: Print Preview, defect, P1)

Description

[rods (gone)]

Comment 1

[karnaze (gone)]

nsbeta1+. 

Comment 2

[rods (gone)]

Attachment: patch

Although the front-end should be disabled and not allow the user to make any
changes to PP while the document is printing. This samll fix is back-end
insurance to keep a crash from happening.

Comment 3

[Samir Gehani]

Mine.  Nominating for nav triage to look at since this bug was nsbeta1+ by the
backend team.  

The work will take a couple of days and the risk is low since it can probably
only makes things better, not worse: we will only be adding a progress listener
to print.  We'll disable the UI while printing and reenable it when the progress
listener indicates the print job has been sent of or has failed.  

If only the backend patch is checked in I believe this is not too heinous a bug
at this point in the release schedule.

Comment 4

[Peter Trudelle]

steps to reproduce?

Comment 5

[Samir Gehani]

Here's what I did on a Win2K trunk mozilla build dated 2002032803:

(1) Print previewed http://slashdot.org (roughly 6 pages long).
(2) Clicked the ``Print...'' button from the print preview toolbar.
(3) Clicked the ``Print'' button on the print dialog that popped up.
(4) Start scaling the page down while the print progress dialog was still up.
(5) I saw an alert that said: ``Printing failed for some reason.''  
(6) When I dismissed the alert by clicking the ``OK'' button I crashed.

I still think this will affect a limited audience since folks don't tend to
scale once they have sent a document for printing.

Rod, 
Please confirm or modify my steps.  Thanks.

Comment 6

[Peter Trudelle]

Is the backend patch already checked in?  Why would we want to spend two more
days on this if it already prevents a crash?

Comment 7

[Peter Trudelle]

nsbeta1+ per Nav triage team, adt3. Please just checkin the backend patch, not
worth 2 days of Samir's time to do the 'right' fix.

Comment 8

[Samir Gehani]

-> rods to checkin the backend patch

Comment 9

[Kevin McCluskey (gone)]

[adt2] crash during printing.

Comment 10

[Marc Attinasi]

Comment on attachment 73942 [details] [diff] [review]
patch

Good safety checks - sr=attinasi

Comment 11

[kinmoz]

Comment on attachment 73942 [details] [diff] [review]
patch

r=[e-mail]

Comment 12

[Kevin McCluskey (gone)]

adt1.0.0

Comment 13

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin into 1.0.

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 73942 [details] [diff] [review]
patch

a=[e-mail]

Comment 15

[rods (gone)]

fixed

Comment 16

[sujay]

verified in 4/10 build.

Comment 17

[R.K.Aa.]

was this checked in on the branch? (see bug 137902)

Comment 18

[Asa Dotzler [:asa]]

based on the date this was resolved it landed before the branch was cut.