Closed Bug 1307164 Opened 8 years ago Closed 8 years ago

Enable ECMAScript's Intl API on larch

Categories

(L20n :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Unassigned)

References

Details

(Whiteboard: [gecko-l20n])

Attachments

(1 file)

This is a mirror bug to bug 1215247.

For our work in bug 1303883 we need to have the Intl API enabled in Android builds of larch.
Blocks: 1303883
Landed in http://hg.mozilla.org/projects/larch/rev/836e720e70ce.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Looks like this broke our XPCShell integration tests:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be582da09d8

I'm looking into it.
Zibi, any idea why the XPCShell tests for mozintl would fail with this patch?
Flags: needinfo?(gandalf)
Hey :m_kato, for our work on L20n in Desktop and Android I landed your patch from bug 1215247 on larch.  I ran into a XPCShell test failure:

TEST-UNEXPECTED-FAIL | intl/locale/tests/unit/test_intl_on_workers.js | xpcshell return code: 0
SyntaxError: Failed to load worker script at "chrome://locale/content/intl_on_workers_worker.js

I was able to reproduce this locally and I also verified that the worker file is correctly being registered in the chrome registry under the above URI.  Do you know what might be the cause of the failure?  I'm not quite sure where that SyntaxError is coming from.
Flags: needinfo?(m_kato)
(In reply to Staś Małolepszy :stas from comment #4)
> Hey :m_kato, for our work on L20n in Desktop and Android I landed your patch
> from bug 1215247 on larch.  I ran into a XPCShell test failure:
> 
> TEST-UNEXPECTED-FAIL | intl/locale/tests/unit/test_intl_on_workers.js |
> xpcshell return code: 0
> SyntaxError: Failed to load worker script at
> "chrome://locale/content/intl_on_workers_worker.js
> 
> I was able to reproduce this locally and I also verified that the worker
> file is correctly being registered in the chrome registry under the above
> URI.  Do you know what might be the cause of the failure?  I'm not quite
> sure where that SyntaxError is coming from.

Even if I comment out Intl usage on this script, this test causes SyntaxError.  When using default (--with-intl-api=no), it will causes same error even if changing to "let myLocale = null;".  So I think that this doesn't depends on Intl API.
Flags: needinfo?(m_kato)
Also, we turn off all worker tests into dom/workers/test/xpcshell/* on Android's xpcshell.
(In reply to Makoto Kato [:m_kato] from comment #6)

> Even if I comment out Intl usage on this script, this test causes
> SyntaxError.  When using default (--with-intl-api=no), it will causes same
> error even if changing to "let myLocale = null;".  So I think that this
> doesn't depends on Intl API.

Thanks for looking into this!  I also tried something as simple as `var a = 1;` and still got the SyntaxError, but wasn't sure if I was testing the right thing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8798868 [details]
Bug 1307164 - Enable Intl API on Android; fix mozIntl tests.

https://reviewboard.mozilla.org/r/84238/#review82868
Attachment #8798868 - Flags: review?(gandalf) → review+
https://hg.mozilla.org/projects/larch/rev/d151ab07062e783e89e401655dbd6727cf29a01f
Bug 1307164 - Enable Intl API on Android; fix mozIntl tests. r=gandalf
Closing this as fixed.  The one failing test isn't probably related to this and should be taken care of as a separate issue.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Flags: needinfo?(gandalf)
Resolution: --- → FIXED
Depends on: 1309447
We managed to get this landed on larch without bug 1309447.
No longer depends on: 1309447
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: