1307227 - Land support for profiling without any addon in tree

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

This is a meta bug for having the ability to start/stop profiling, view profiles, etc in tree without any addons.

Would probably have this pref'd off by default? But either way, it should be available in all releases and custom builds.

Comment 1

[Greg Tatum [:gregtatum]]

Might as well use this existing bug. I'm planning on working no landing the Gecko Profiler Addon code in tree, and maintain the mechanism to load profiles in profiler.firefox.com.

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1307227 - Copy over the Gecko Profiler Addon files; r=julienw

This bug's first commit will be a non-working revision.

These files are taken from:

https://github.com/firefox-devtools/Gecko-Profiler-Addon/commit/68d5de9c9ff64096181bc1a45098d6c205172faa

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1307227 - Update the devtools browser menu to take isDefaultChecked

Depends on D31547

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: (Broken out to Bug 1552565, do not review) - Fix event listener for CustomizableUI when destroying widgets

The WebExtensions do not delete the _addedEventListeners property from
the view node when the widget is destroyed. This stops the widget from
correctly having events dispatched to it, as the initialization code
assumes that it has already been set up.

Depends on D31547

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1307227 - Update the profiler's popup code to work in Gecko; r=julienw

This commit represents the changes needed to convert the existing
Gecko Profiler Add-on code to work outside of the WebExtensions
environment. A following commit will actually wire it into the
rest of the browser.

Depends on D31626

Comment 6

[Greg Tatum [:gregtatum]]

Attachment: Bug 1307227 - Ensure the provider is always initialized for calls to lazyRequireGetter; r=ochameau

The performance profiler pop-up menu wants to be near DevTools, but work
without the complete DevTools initialization. This patch adds a public
method to perform the initialization code of initializing the provider.

Depends on D31627

Comment 7

[Greg Tatum [:gregtatum]]

Attachment: Bug 1307227 - Integrate the profiler popup widget into the browser; r=jdescottes

This commit takes the popup, and wires it up the button using the
CustomizableUI interface. It is integrated with the DevTools initialization
code.

Depends on D31628

Comment 8

[Florian Quèze [:florian]]

Sylvestre/Calixte, could the bot avoid adding back a change it did previously that has been reverted by the bug's assignee?

Comment 9

[Sylvestre Ledru [:Sylvestre]]

The bot is correct here.
If this isn't a meta bug, the meta keyword should be removed. If it is, [meta] should be part of the title (this for the list of bug/search).

Comment 10

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6daf6a6ccd02c8f2e913decea05d4832e4484283

Comment 11

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b79601f6a3080645ab394f39adf2ad65503684b

Comment 12

[Greg Tatum [:gregtatum]]

Attachment: Bug 1307227 - Add a runtime check for when the profiler button is enabled and checked; r=julienw

Comment 13

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7ed9ec931659bd71af9d012a8c35c116749f19d

Comment 14

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1223295f089117f41dfd7bb8a37163f8b933381b

Comment 15

[Greg Tatum [:gregtatum]]

Latest run with some changes to keyboard shortcut handling: https://treeherder.mozilla.org/#/jobs?repo=try&revision=85ef6422ee7f5373cd36252429f33442e745c9b0

Comment 16

[Greg Tatum [:gregtatum]]

This try run changes the strategy to only add the <key> elements when the menu button is enabled. https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8be4aaa4c51f67384c1c3ea54bb0bbcc6f5c95e

Comment 17

[Greg Tatum [:gregtatum]]

Based on my try run above, the failures I encountered look unrelated to my patch. I recreated the failures locally without my patch on my windows machine, so I'm going to try and land this now.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a395d78de549
Copy over the Gecko Profiler Addon files; r=julienw
https://hg.mozilla.org/integration/autoland/rev/2a97b26893c4
Update the profiler's popup code to work in Gecko; r=julienw
https://hg.mozilla.org/integration/autoland/rev/2960e77ad5a6
Ensure the provider is always initialized for calls to lazyRequireGetter; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/020a3fc71e39
Integrate the profiler popup widget into the browser; r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/a8a326afa3f8
Add a runtime check for when the profiler button is enabled and checked; r=julienw

Comment 19

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a395d78de549
https://hg.mozilla.org/mozilla-central/rev/2a97b26893c4
https://hg.mozilla.org/mozilla-central/rev/2960e77ad5a6
https://hg.mozilla.org/mozilla-central/rev/020a3fc71e39
https://hg.mozilla.org/mozilla-central/rev/a8a326afa3f8

Comment 20

[Pascal Chevrel:pascalc (PTO until April 26)]

I think this is something that should be mentioned in our Nightly Release notes as this is our most technical user base and incitating them to profile pages and report bugs about performance is a worthy. Greg, could you request an addition to the release notes? https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_nominate_a_bug_for_release_notes_addition.3F

Is there some general documentation, screencast or blog post we could link this release note to?

Thanks

Comment 21

[Greg Tatum [:gregtatum]]

I think I'd like 1 more cycle in nightly before releasing information about it. There are still some outstanding usability issues. I will follow-up with information once I fix a few more things.