1307899 - Convert component tests to Enzyme

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Lin Clark [:linclark]]

Originally posted by:linclark

see https://github.com/devtools-html/gecko-dev/issues/180

In #178 I got Enzyme working. If there are no objections to the way it is working, then we should move all component tests to use it.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1307899 - Remove renderComponent and switch consumers to using Enzyme instead; .

Review commit: https://reviewboard.mozilla.org/r/218742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218742/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8949429 [details]
Bug 1307899 - Remove renderComponent and switch consumers to using Enzyme instead; .

https://reviewboard.mozilla.org/r/218742/#review226034

Looks good except of the "EvaluationResult" test.

I am seeing the following error when running it:

  1) EvaluationResult component: displays a [Learn more] link:
     TypeError: Cannot read property '_renderedComponent' of undefined
      at WrapperComponent.getWrappedComponent (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\enzyme\build\ReactWrapperComponent.js:94:54)
      at new ReactWrapper (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\enzyme\build\ReactWrapper.js:100:34)
      at mount (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\enzyme\build\mount.js:19:10)
      at Context.<anonymous> (C:/src/mozilla.org/mozilla-central/devtools/client/webconsole/new-console-output/test/components/evaluation-result.test.js:73:21)
      at callFn (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runnable.js:326:21)
      at Test.Runnable.run (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runnable.js:319:7)
      at Runner.runTest (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:422:10)
      at C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:528:12
      at next (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:342:14)
      at C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:352:7
      at next (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:284:14)
      at Immediate.<anonymous> (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:320:5)


Looks like this one depends on bug 1436690, correct?
If yes, let's wait till this is fixed and in Nightly.

Honza

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8949429 [details]
Bug 1307899 - Remove renderComponent and switch consumers to using Enzyme instead; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218742/diff/1-2/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

this needs to be rebased on top of Bug 1438476

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8949429 [details]
Bug 1307899 - Remove renderComponent and switch consumers to using Enzyme instead; .

https://reviewboard.mozilla.org/r/218742/#review226912

Looks fine to me

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbbd357dcb92
Remove renderComponent and switch consumers to using Enzyme instead; r=bgrins.

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bbbd357dcb92