Closed Bug 1307935 Opened 8 years ago Closed 4 years ago

Remove the MessageContainer component

Categories

(DevTools :: Console, task, P4)

Product:
DevTools
Component:
Console
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: linclark, Unassigned)

Details

Originally posted by:linclark

see https://github.com/devtools-html/gecko-dev/issues/336

Now that #226 has landed, I think the component structure is pretty set. When we were originally working on the component code, I thought we might move more up to the container, but having the shared code at a lower level in the component tree turns out to be more useful. Therefore, I think we can just move the switcher logic up to ConsoleOutput's map function.
Priority: -- → P2
Whiteboard: new-console
Blocks: enable-new-console
Flags: qe-verify-
Priority: P2 → P3
Whiteboard: new-console → [reserve-new-console]
Whiteboard: [reserve-new-console] → [reserve-console-html]
Priority: P3 → P4
Whiteboard: [reserve-console-html]
Product: Firefox → DevTools
Mentor: nchevobbe
Type: enhancement → task
Keywords: good-first-bug
Summary: Remove the message container component → Remove the MessageContainer component

after looking into this a bit, I think this might be tricky because of the checks on shouldComponentUpdate

Mentor: nchevobbe
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: good-first-bug
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.