Closed Bug 1308019 Opened 8 years ago Closed 7 years ago

Provide Tomcat support for TLS v1.1 and TLS v1.2 via NSS through JSS

Categories

(JSS Graveyard :: Library, defect)

Product:
JSS Graveyard
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: elio.maldonado.batiz, Assigned: cfu)

References

Details

Attachments

(1 file, 3 obsolete files)

support TLS1.1 and TLS1.2
17.54 KB, patch
Details | Diff | Splinter Review 
      No description provided.
Attached patch support TLS 1.1 and TLS1.2 (obsolete) — — Splinter Review 
Downstream patch by Christina Fu, not ready yet for reviw
Comment on attachment 8798966 [details] [diff] [review]
support TLS 1.1 and TLS1.2

Review of attachment 8798966 [details] [diff] [review]:
-----------------------------------------------------------------

This patch caused build to fail (1 error and 4 warnings) will attach the error log.
Attached file build.log (obsolete) — 

    
    

    
  

      
      
      
      

        Attached file
          
        error log (obsolete)
        — 
      

    


  
Generated via make clean all 1> ../tls-1.2-build.log 2> ../tls-1.2-error.log

    
  
Assignee: glenbeasley → cfu

    
    

    
  


  
This one solves the problems I had once the one for Bug 1344292 has been committed.

        Attachment #8798966 -
        Attachment is obsolete: true

        Attachment #8835188 -
        Attachment is obsolete: true

        Attachment #8835189 -
        Attachment is obsolete: true

        Attachment #8843535 -
        Flags: review?(cfu)

    
    

    
  
Comment on attachment 8843535 [details] [diff] [review]
support TLS1.1 and TLS1.2

Review of attachment 8843535 [details] [diff] [review]:
-----------------------------------------------------------------

This patch matches closely with my original Fedora downstream JSS patch jss-support-TLS1_1-TLS1_2.patch
with the exception of the enum downshifting which most likely was caused by the merge with upstream existing numbers clash.
That was fine.
However, the following
#define JSSL_enums_size 36
should be
#define JSSL_enums_size 35

You can just make that correction and it's good.

    
    

    
  
Pushed: https://hg.mozilla.org/projects/jss/rev/c37b03bda9afc470bd412bf89428f17c120dc995
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

    
    

    
  
Historical Note:
# RHBZ 816396 - Provide Tomcat support for TLS v1.1 and TLS v1.2 via NSS through JSS
# https://bugzilla.redhat.com/show_bug.cgi?id=816396
# author: cfu@redhat.com
# Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1308019
#Patch26:        jss-support-TLS1_1-TLS1_2.patch

    
  
Target Milestone: --- → 4.4

    
  

        Attachment #8843535 -
        Flags: review?(cfu)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: