Closed
Bug 1308032
Opened 8 years ago
Closed 8 years ago
Cache::Memcached::Fast from bugzilla bug 1189281 and bug 1274764
Categories
(bugzilla.mozilla.org :: General, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dylan)
References
Details
Attachments
(1 file, 1 obsolete file)
4.88 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
This is quite a performance win especially with bug 1274764.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8798234 -
Flags: review?(dkl)
Comment 2•8 years ago
|
||
Comment on attachment 8798234 [details] [diff] [review] 1308032_1.patch Review of attachment 8798234 [details] [diff] [review]: ----------------------------------------------------------------- Otherwise works once I make the suggested changed. Fix on commit. r=dkl ::: Bugzilla/Memcached.pm @@ -28,4 @@ > > # always return an object to simplify calling code when memcached is > # disabled. > - my $servers = Bugzilla->get_param_with_override('memcached_servers'); Do not remove this line as we still need to be able to override in localconfig. @@ +37,2 @@ > namespace => $self->{namespace}, > }); Need require Cache::Memcached::Fast; ::: Makefile.PL @@ +120,4 @@ > memcached => { > description => 'Memcached Support', > prereqs => { > + runtime => { requires => { 'Cache::Memcached::Fast' => '0.17' } } Add to 'bmo' feature.
Attachment #8798234 -
Flags: review?(dkl) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8798234 [details] [diff] [review] 1308032_1.patch (In reply to David Lawrence [:dkl] from comment #2) > Comment on attachment 8798234 [details] [diff] [review] > 1308032_1.patch > > Review of attachment 8798234 [details] [diff] [review]: > ----------------------------------------------------------------- > > @@ +37,2 @@ > > namespace => $self->{namespace}, > > }); > > Need > > require Cache::Memcached::Fast; This was due to not re-running 'perl Makefile.PL' after applying the patch to regenerate MYMETA.*. After doing that the above fix is not needed as the module is loaded by Bugzilla->feature. I will need to add the command to 'bz patch' in order to not have this issue in the future. Other fixes can be done on commit. dkl
Assignee | ||
Comment 4•8 years ago
|
||
Quick sanity check please.
Attachment #8798234 -
Attachment is obsolete: true
Attachment #8799462 -
Flags: review?(dkl)
Comment 5•8 years ago
|
||
Comment on attachment 8799462 [details] [diff] [review] 1308032_2.patch Review of attachment 8799462 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl
Attachment #8799462 -
Flags: review?(dkl) → review+
Assignee | ||
Comment 6•8 years ago
|
||
To git@github.com:mozilla-bteam/bmo.git b14f11a..9f4d372 master -> master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•