1308215 - Create Carthage dependency wrapper around page-metadata-parser instead of directly pulling in JS library

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Stephan Leroux [:sleroux]]

Originally the branch I had for setting up the page-metadata-parser code in iOS had the bundled JS file included in the repo. With the recent changes to the PR I had open [1] to get it merged into master, we no longer have it committed in git. In order to properly import the library into Firefox for iOS one option is to create a new carthage dependency that wraps around the JS library and has the script bundling as part of the build phases. This also gives us the option to abstract out the parsing code from the JS if we plan on using a server-side service or alternative client code.

Unfortunately since the PR has been merged and updated, new clean checkouts using Carthage will result in build errors in Firefox for iOS because the bundle file is missing. Since this can effect building the project now, I'm going to move this into this sprint/P1 so we can avoid any build issues from contributors.

[1] https://github.com/mozilla/page-metadata-parser/pull/68

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Github PR

Instead of sinking time into getting the Carthage dependency up right now, I've committed the JS bundle directly into the repo temporarily until we can get a Carthage dependency up and running for it.

Comment 2

[Stephan Leroux [:sleroux]]

Temporary fix: master https://github.com/mozilla-mobile/firefox-ios/commit/e981bd333d750559383ebd4cb5271195543faf68

Comment 3

[Stephan Leroux [:sleroux]]

Moving to P2 as this should be something we do before we ship AS with metadata parsing.

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2189

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: WebMetadataKit Library

The library

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8804007 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2189

Makes sense to me!

Comment 7

[Stephan Leroux [:sleroux]]

master https://github.com/mozilla-mobile/firefox-ios/commit/1d083b62ef9a5d233819170959a515c7546fcba9