Closed Bug 1308477 Opened 8 years ago Closed 8 years ago

Merge the two netmonitor.css style files into one

Categories

(DevTools :: Netmonitor, defect, P1)

defect

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Iteration:
52.2 - Oct 17
Tracking Status
firefox52 --- fixed

People

(Reporter: rickychien, Assigned: jsnajdr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [netmonitor])

Attachments

(1 file)

There are now two netmonitor.css files:
devtools/client/netmonitor/netmonitor.css
devtools/client/themes/netmonitor.css
We could merge them into one file in the “themes” directory

Other tools do that, too. The current division doesn’t follow any logic, it’s mostly random. Many CSS styles will get altered in the netmonitor.html project.
Whiteboard: [devtools-html]
Assignee: nobody → jsnajdr
Comment on attachment 8799322 [details]
Bug 1308477 - Merge the two netmonitor.css style files into one

https://reviewboard.mozilla.org/r/84532/#review83098

LGTM!

Honza
Attachment #8799322 - Flags: review?(odvarko) → review+
Pushed by jsnajdr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/515e6d07c0c2
Merge the two netmonitor.css style files into one r=Honza
https://hg.mozilla.org/mozilla-central/rev/515e6d07c0c2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Iteration: --- → 52.2 - Oct 17
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [netmonitor]
Just copy-paste change, QA not needed.

Honza
Flags: qe-verify? → qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: