Closed
Bug 1308480
Opened 8 years ago
Closed 8 years ago
Move sorting functions to their own module
Categories
(DevTools :: Netmonitor, defect, P1)
DevTools
Netmonitor
Tracking
(firefox52 verified)
Tracking | Status | |
---|---|---|
firefox52 | --- | verified |
People
(Reporter: rickychien, Assigned: jsnajdr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [netmonitor])
Attachments
(1 file)
Netmonitor-view.js contains sorting functions like _byFile or _byTiming. - Move them to a sort-predicates.js module. - Fix the sorting functions. Array.sort expects a function that returns -1/0/+1, but our sorting functions return true/false.
Updated•8 years ago
|
Whiteboard: [devtools-html]
Reporter | ||
Updated•8 years ago
|
Updated•8 years ago
|
Whiteboard: [netmonitor]
Updated•8 years ago
|
Flags: qe-verify+
QA Contact: ciprian.georgiu
Assignee | ||
Comment 1•8 years ago
|
||
QA instructions: verify that netmonitor columns are still sorted correctly.
Assignee: nobody → jsnajdr
Depends on: 1309120
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8800195 [details] Bug 1308480 - Move sorting functions to their own module https://reviewboard.mozilla.org/r/85192/#review83760 Nice! Just one nit, R+ assuming Try is green. Honza ::: devtools/client/netmonitor/netmonitor-view.js:22 (Diff revision 1) > -const {getFormDataSections, formDataURI, writeHeaderText, getKeyWithEvent} = require("./request-utils"); > +const {getFormDataSections, formDataURI, writeHeaderText, > + getKeyWithEvent, getUriHostPort} = require("./request-utils"); Put every imported function on separate line. ::: devtools/client/netmonitor/sort-predicates.js:7 (Diff revision 1) > + > +const { getAbbreviatedMimeType, > + getUriNameWithQuery, > + getUriHostPort, > + loadCauseString } = require("./request-utils"); > + I like how the import statement is formatted, it would be great to use it at other places too. (see my next comment)
Attachment #8800195 -
Flags: review?(odvarko) → review+
Comment hidden (mozreview-request) |
Pushed by jsnajdr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1b42244a8a8c Move sorting functions to their own module r=Honza
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b42244a8a8c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Updated•8 years ago
|
Iteration: --- → 52.2 - Oct 17
Updated•8 years ago
|
Priority: -- → P1
Comment 7•8 years ago
|
||
I can confirm that the netmonitor columns are still sorted correctly on latest Nightly build 52.0a1 (2016-10-17) under the following OSes: - Windows 10 x64 - Mac OS X 10.11.4 - Ubuntu 16.04 LTS That being said I will mark this bug as verified fixed.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•