Closed
Bug 1308495
Opened 8 years ago
Closed 8 years ago
Move event constants into a new module
Categories
(DevTools :: Netmonitor, defect, P1)
DevTools
Netmonitor
Tracking
(firefox52 fixed)
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: rickychien, Assigned: jsnajdr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [netmonitor])
Attachments
(1 file)
This is a code cleaning task before we migrate Net panel to HTML. - Extracts constants from netmonitor-controller.js and create new event.js module See: https://github.com/jsnajdr/gecko-dev/blob/98372c04339dfe29b8affa4d5e3766920f190700/devtools/client/netmonitor/events.js
Updated•8 years ago
|
Whiteboard: [devtools-html]
Updated•8 years ago
|
Whiteboard: [netmonitor]
Updated•8 years ago
|
Flags: qe-verify-
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8800193 [details] Bug 1308495 - Move event constants into a new module https://reviewboard.mozilla.org/r/85184/#review83744 R+, assuming try is green. Honza
Attachment #8800193 -
Flags: review?(odvarko) → review+
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] from comment #2) > R+, assuming try is green. Try is running here, together with the sorting patch from bug 1308480: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1753ddc130d For landing, this depends on landing bug 1309120 (RequestsMenuView separation) first.
Pushed by jsnajdr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/797f70b3ef65 Move event constants into a new module r=Honza
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/797f70b3ef65
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Updated•8 years ago
|
Iteration: --- → 52.2 - Oct 17
Updated•8 years ago
|
Priority: -- → P1
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•