1308884 - [Static Analysis][Missing varargs init or cleanup] In function ReportOnCallerUTF8

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that va_end is not called in function that uses va_list with va_start:

>>    va_list ap;
>>    va_start(ap, format);
>>
>>    char* buf = JS_vsmprintf(format, ap);
>>    if (!buf) {
>>        return NS_ERROR_OUT_OF_MEMORY;
>>    }
>>
>>    JS_ReportErrorUTF8(callerContext, "%s", buf);
>>    JS_smprintf_free(buf);
>>
>>    return NS_OK;

va_end(ap) should be called on if branch but also on the normal return path.

Comment 1

[Andi [:andi]]

Attachment: Bug 1308884 - clean return from functions that use variable number of arguments.

Review commit: https://reviewboard.mozilla.org/r/84560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84560/

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8799366 [details]
Bug 1308884 - clean return from functions that use variable number of arguments.

https://reviewboard.mozilla.org/r/84560/#review83204

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68706d567be6
clean return from functions that use variable number of arguments. r=bholley

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/68706d567be6