Closed
Bug 1308890
Opened 8 years ago
Closed 8 years ago
Make use of ScopedAutoSECItem in CryptoKey.cpp
Categories
(Core :: Security, defect)
Core
Security
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
References
Details
Attachments
(1 file)
One of the things ScopedAutoSECItem is useful for is getting rid of this pattern:
> ScopedSECItem item(SECITEM_AllocItem(nullptr, nullptr, 0));
While this pattern works, ScopedAutoSECItem is slightly superior in that it doesn't unnecessarily cause a SECItem to be allocated from the heap. Moreover, this moves us further away from Scoped.h, which is deprecated.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8800041 [details] Bug 1308890 - Make use of ScopedAutoSECItem in CryptoKey.cpp. https://reviewboard.mozilla.org/r/85048/#review84218
Attachment #8800041 -
Flags: review?(rlb) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•8 years ago
|
||
Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=41520f8f1150f06c41857700e931695760cf88ae
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/32425af1283d Make use of ScopedAutoSECItem in CryptoKey.cpp. r=rbarnes
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/32425af1283d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•