Closed Bug 1309228 Opened 8 years ago Closed 8 years ago

[geckoview] Remove moar JavaPanZoomController (JPZ) from mobile/android

Categories

(Firefox for Android Graveyard :: Toolbar, defect, P3)

52 Branch
All
Android
defect

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1307522 +++

There's more JPZ goop that can be removed. Specifically:
setScrollClampingSize in browser.js, which allows removing
gScreenWidth/gScreenHeight in browser.js, which allows removing
the window arguments code that passes in width and height
Priority: -- → P3
Hardware: Unspecified → All
Comment on attachment 8799769 [details]
Bug 1309228 - Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ.

https://reviewboard.mozilla.org/r/84892/#review83512
Attachment #8799769 - Flags: review+
Comment on attachment 8799770 [details]
Bug 1309228 - Now that the width and height arguments are no longer needed in browser.js, remove those too.

https://reviewboard.mozilla.org/r/84894/#review83514
Attachment #8799770 - Flags: review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/650200515d54
Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ. r=rbarker
https://hg.mozilla.org/integration/autoland/rev/b01926251add
Now that the width and height arguments are no longer needed in browser.js, remove those too. r=rbarker
https://hg.mozilla.org/mozilla-central/rev/650200515d54
https://hg.mozilla.org/mozilla-central/rev/b01926251add
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment on attachment 8799769 [details]
Bug 1309228 - Remove the setScrollClampingSize function in browser.js that's not used since JPZ was replaced by APZ.

https://reviewboard.mozilla.org/r/84892/#review85062
Attachment #8799769 - Flags: review?(snorp) → review+
Comment on attachment 8799770 [details]
Bug 1309228 - Now that the width and height arguments are no longer needed in browser.js, remove those too.

https://reviewboard.mozilla.org/r/84894/#review85064
Attachment #8799770 - Flags: review?(snorp) → review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: