Closed Bug 1309594 Opened 8 years ago Closed 8 years ago

Test comparator is wrong

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Product:
Firefox Build System
Component:
Android Studio and Gradle Integration
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: volker.mische, Assigned: snorp)

Details

Attachments

(1 file)

Fix typo in Android build-tools detection
1.22 KB, patch
sebastian
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160607223741

Steps to reproduce:

Configure with |./mach configure|


Actual results:

checking for Android build-tools... /home/vmx/src/c/b2g/gecko-dev/old-configure: 11269: test: unexpected operator



Expected results:

DEBUG: configure: error: You must install the Android build-tools version 23.0.3.  Try |mach bootstrap|.  (Looked for /home/vmx/src/rust/android/android-sdk-linux/build-tools/23.0.3)

The fix is to change the `==` to `=` in https://github.com/mozilla/gecko-dev/blob/d0e135f5d17dc7415f7fdccbbeddc092a1c4d3fb/build/autoconf/android.m4#L263
Who owns this code?
Flags: needinfo?(snorp)
Thanks for the patch!
Flags: needinfo?(snorp)
Comment on attachment 8806095 [details] [diff] [review]
Fix typo in Android build-tools detection

Review of attachment 8806095 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8806095 - Flags: review?(s.kaspari) → review+
Assignee: nobody → snorp
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(s.kaspari)
Flags: needinfo?(s.kaspari)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c9d27b4ad3e
Fix typo in Android build-tools detection r=sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1c9d27b4ad3e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 52 → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: