Closed
Bug 1309599
Opened 8 years ago
Closed 8 years ago
Update e10s related nsAppRunner code for current RTL support
Categories
(Core :: DOM: Content Processes, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(1 file)
|
2.28 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
Need to do a checkup on the system add-on to determine how it handles RTL decisions. Thew following releases should be targeted: RTL/e10s platform support: WIN = 48 OSX = 50 LINUX = 52 Felipe, do we need to make some changes here or are we good? I'm guessing linux needs to be added to the list since that bug just closed out. RTL bugs: Bug 1033483 - [e10s][RTL] Do bidi state detection in the parent process on Linux Bug 1033488 - [e10s][RTL] Do bidi state detection in the parent process on Windows Bug 1277831 - Enable e10s for Windows and OSX RTL users
Flags: needinfo?(felipc)
|
||
Comment 1•8 years ago
|
||
The RTL decision is entirely made by nsAppRunner.cpp. So you just need to make sure that the block of code from bug 1277831 is correctly existent or not on each version. FWIW, my understanding was that both Win and OSX were supported from version 50. (and not 48 for Win as you mentioned)
Flags: needinfo?(felipc)
|
Assignee | |
Comment 2•8 years ago
|
||
(In reply to :Felipe Gomes (needinfo me!) from comment #1) > The RTL decision is entirely made by nsAppRunner.cpp. So you just need to > make sure that the block of code from bug 1277831 is correctly existent or > not on each version. FWIW, my understanding was that both Win and OSX were > supported from version 50. (and not 48 for Win as you mentioned) Thanks. I'll get this updated here.
Summary: Make sure the e10s system add-on is up to date regarding RTL support → Update e10s related nsAppRunner code for current RTL support
|
|
Assignee | |
Comment 3•8 years ago
|
||
Assignee: nobody → jmathies
Attachment #8800405 -
Flags: review?(felipc)
|
|
||
Updated•8 years ago
|
Attachment #8800405 -
Flags: review?(felipc) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ee3fbfa087a5 Turn e10s on for RTL linux users. r=felipe
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ee3fbfa087a5
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•