1310003 - Rename and lint deprecated .eslintrc files

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This is a mirror of bug 1251003, with the addition of actually having eslint lint the config file.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1 (no whitespaces)

For convenience, here is the same patch but with whitespace changes ignored.

Comment 3

[[:MakeMyDay]]

Comment on attachment 8800847 [details] [diff] [review]
Fix - v1

Review of attachment 8800847 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I always was wondering why the deprecated fromat was used.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://hg.mozilla.org/comm-central/rev/b0d4176aaa7a033ce5e725a922a0d9159728c7d4

Comment 5

[Markus Adrario [:Taraman]]

Since bug 1251003 landed, we need to cope for the changes in the toolkit eslintrc files.

When linting, I get a lot of indentation errors.
Have these been there before?

Comment 6

[Markus Adrario [:Taraman]]

Attachment: Fix V2

This change the filenames in the config files of calendar

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8803608 [details] [diff] [review]
Fix V2

Good catch, thanks. r=philipp

For the indent changes, this is a pending issue. I've fixed most of the xbl processor issues, but the one missing is to detect indent correctly.

m-c uses two space indent in xbl files, even in the code. We use two space for the xml and four space for the code. I have a patch pending that uses the closing tag indent to check what the base indent would be. This works pretty well for both m-c and c-c, as long as we indent all our xbl method bodies by two more spaces.

In the meanwhile, go to  mozilla/tools/lint/eslint/node_modules/eslint-plugin-mozilla/lib/processors/xbl-bindings.js and change INDENT from 2 to 4. This will reset as soon as you mach eslint --setup again, if that is annoying to you then you could also change it in the source (drop node_modules from above path) and then run mach eslint --setup again.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://hg.mozilla.org/comm-central/rev/da9bb0d96cc8487f057e1fe1c7e06b2e5b0b359e

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Filed bug 1312191 for the indent issue btw