Closed
Bug 1310111
Opened 8 years ago
Closed 8 years ago
Don't double-call EnsureProcessTerminated for the GPU process
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
Details
Attachments
(1 file)
|
830 bytes,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
This is causing crashes when I run opt tests locally, not sure if it's behind some TreeHerder crashes yet.
|
Assignee | |
Comment 1•8 years ago
|
||
GeckoChildProcessHost already calls EnsureProcessTerminated in its destructor, and only does so if the handle is still valid. So calling it here leads to some operations on an invalid handle and Windows throws an exception.
Attachment #8800989 -
Flags: review?(wmccloskey)
Attachment #8800989 -
Flags: review?(wmccloskey) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e63eae10adb1 Don't double-call EnsureProcessTerminated when killing the GPU process. (bug 1310111, r=billm)
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e63eae10adb1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•