1310204 - Wrong units for file zize

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[tad]

During upload, air mozilla is reporting a 2GB file as being 2Gb, and similarly, 126MB completed as 126Mb completed.

These abbreviations should be changed as they represent different units

Comment 1

[Peter Bengtsson [:peterbe]]

What's wrong with "Gb" and "Mb"?

Comment 2

[tad]

Gb = Gigabit
GB = Gigabyte

Mb = Megabit
MB = Megabyte

My file is 2 Gigabytes, not 2 Gigabits

Comment 3

[Peter Bengtsson [:peterbe]]

(In reply to Tom Farrow [:Tad] from comment #2)
> Gb = Gigabit
> GB = Gigabyte
> 
> Mb = Megabit
> MB = Megabyte
> 
> My file is 2 Gigabytes, not 2 Gigabits

I see! 
I didn't know that. I wonder what library we use.

Comment 4

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/airmozilla/pull/768

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/650dc3a000e1d1d68890ef68bff82dd5328612a9
fixes bug 1310204 - Wrong units for file zize (#768)