Closed
Bug 1310245
Opened 8 years ago
Closed 8 years ago
Remove webapps from comm-central. Port Bug 1261019.
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 52.0
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(1 file)
2.90 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Bug 1261019 removed webapps components present in SeaMonkey, Instantbird and Thunderbird.
Comment 1•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/d1c77b5622b86dbf6d7ab90e940f8b1494f90fc0 Bug 1310245 - Remove webapps from comm-central, suite\ part. rs,a=bustage-fix
Comment 2•8 years ago
|
||
TB and IB: https://hg.mozilla.org/comm-central/rev/8166f30a47b0f4cf32f63ad7d875d638ae2305cc
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
Assignee | ||
Comment 3•8 years ago
|
||
SeaMonkey needs an additional tweak. Kent, there are still references in mailnews code for webapps.jsm. Could Bug 1148512 probably be backed out now?
Assignee: nobody → frgrahl
Status: RESOLVED → REOPENED
Flags: needinfo?(rkent)
Attachment #8801209 -
Flags: review?(iann_bugzilla)
Resolution: FIXED → ---
Comment on attachment 8801209 [details] [diff] [review] 1310245-webapps-suite2.patch LGTM r/a=me
Attachment #8801209 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Comment 5•8 years ago
|
||
suite part pushed. https://hg.mozilla.org/comm-central/rev/4ab74b8cea0439e4056e7656d8542471f3c9454e
Comment 6•8 years ago
|
||
(In reply to Frank-Rainer Grahl from comment #3) > Created attachment 8801209 [details] [diff] [review] > 1310245-webapps-suite2.patch > > SeaMonkey needs an additional tweak. > > Kent, there are still references in mailnews code for webapps.jsm. Could Bug > 1148512 probably be backed out now? Those references are just in comments, right? If you want to remove the comments, you may do so r=rkent. As for backing out bug 1148512, It would take some time to back out, I don't see that it is doing any hard, so I would leave it unless you have a concrete reason to back it out.
Flags: needinfo?(rkent)
Assignee | ||
Comment 7•8 years ago
|
||
>> Those references are just in comments, right?
Yupp. I won't change them right now because the explanation for the added lines would then be gone too. So lets just clsoe the bug for now.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•